Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Linux kernel regressions list <regressions@lists.linux.dev>,
	Sasha Levin <sashal@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Bug 219269 - v6.10.10 kernel fails to build when CONFIG_MODULES is disabled
Date: Sat, 14 Sep 2024 09:09:51 +0200	[thread overview]
Message-ID: <2024091428-unison-relocate-4c2b@gregkh> (raw)
In-Reply-To: <bd49aa81-338f-4776-8c45-7c79945c0a81@leemhuis.info>

On Sat, Sep 14, 2024 at 07:02:26AM +0200, Thorsten Leemhuis wrote:
> Hi Greg! I noticed a bug report in bz:
> https://bugzilla.kernel.org/show_bug.cgi?id=219269
> 
> > Fair enough, you get a compiler warning:
> > 
> > kernel/trace/trace_kprobe.c: In function ‘validate_probe_symbol’:
> > kernel/trace/trace_kprobe.c:810:23: error: implicit declaration of function ‘find_module’; did you mean init_module’? [-Wimplicit-function-declaration]
> >   810 |                 mod = find_module(modname);
> >       |                       ^~~~~~~~~~~
> >       |                       init_module
> > kernel/trace/trace_kprobe.c:810:21: error: assignment to ‘struct module *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> >   810 |                 mod = find_module(modname);
> >       |    
> > 
> > but there is no find_module symbol when CONFIG_MODULES is disabled.
> 
> I *very briefly* looked into this. I might be wrong, but looked a bit
> like "tracing/kprobes: Add symbol counting check when module loads"
> caused this and backporting b10545b6b86b7a ("tracing/kprobes: Fix build
> error when find_module() is not available") [v6.11-rc1] would fix this
> (which applies cleanly).
> 
> Shall I ask the reporter to confirm or is that already enough for you?

This is enough, now queued up, thanks.

greg k-h

      reply	other threads:[~2024-09-14  7:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-14  5:02 Bug 219269 - v6.10.10 kernel fails to build when CONFIG_MODULES is disabled Thorsten Leemhuis
2024-09-14  7:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024091428-unison-relocate-4c2b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox