* [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL
@ 2024-09-16 16:53 Thomas Weißschuh
2024-09-16 18:44 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Weißschuh @ 2024-09-16 16:53 UTC (permalink / raw)
To: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Alexander Aring
Cc: netdev, linux-kernel, stable, Thomas Weißschuh
The rpl sr tunnel code contains calls to dst_cache_*() which are
only present when the dst cache is built.
Select DST_CACHE to build the dst cache, similar to other kconfig
options in the same file.
Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
Cc: stable@vger.kernel.org
---
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
net/ipv6/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 08d4b7132d4c..1c9c686d9522 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -323,6 +323,7 @@ config IPV6_RPL_LWTUNNEL
bool "IPv6: RPL Source Routing Header support"
depends on IPV6
select LWTUNNEL
+ select DST_CACHE
help
Support for RFC6554 RPL Source Routing Header using the lightweight
tunnels mechanism.
---
base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
change-id: 20240916-ipv6_rpl_lwtunnel-dst_cache-22561978f35f
Best regards,
--
Thomas Weißschuh <thomas.weissschuh@linutronix.de>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL 2024-09-16 16:53 [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL Thomas Weißschuh @ 2024-09-16 18:44 ` Simon Horman 2024-09-16 18:48 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2024-09-16 18:44 UTC (permalink / raw) To: Thomas Weißschuh Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexander Aring, netdev, linux-kernel, stable On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote: > The rpl sr tunnel code contains calls to dst_cache_*() which are > only present when the dst cache is built. > Select DST_CACHE to build the dst cache, similar to other kconfig > options in the same file. > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel") > Cc: stable@vger.kernel.org > --- > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL 2024-09-16 18:44 ` Simon Horman @ 2024-09-16 18:48 ` Simon Horman 2024-09-16 18:54 ` Thomas Weißschuh 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2024-09-16 18:48 UTC (permalink / raw) To: Thomas Weißschuh Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexander Aring, netdev, linux-kernel, stable On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote: > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote: > > The rpl sr tunnel code contains calls to dst_cache_*() which are > > only present when the dst cache is built. > > Select DST_CACHE to build the dst cache, similar to other kconfig > > options in the same file. > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel") > > Cc: stable@vger.kernel.org > > --- > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> > > Reviewed-by: Simon Horman <horms@kernel.org> > Tested-by: Simon Horman <horms@kernel.org> # build-tested Sorry Thomas, I missed one important thing: Your Signed-off-by line needs to go above the scissors ('---') because when git applies your patch nothing below the scissors is included in the patch description. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL 2024-09-16 18:48 ` Simon Horman @ 2024-09-16 18:54 ` Thomas Weißschuh 2024-09-16 19:04 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Thomas Weißschuh @ 2024-09-16 18:54 UTC (permalink / raw) To: Simon Horman Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexander Aring, netdev, linux-kernel, stable On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote: > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote: > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote: > > > The rpl sr tunnel code contains calls to dst_cache_*() which are > > > only present when the dst cache is built. > > > Select DST_CACHE to build the dst cache, similar to other kconfig > > > options in the same file. > > > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel") > > > Cc: stable@vger.kernel.org > > > --- > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> > > > > Reviewed-by: Simon Horman <horms@kernel.org> > > Tested-by: Simon Horman <horms@kernel.org> # build-tested > > Sorry Thomas, I missed one important thing: > > Your Signed-off-by line needs to go above the scissors ('---') > because when git applies your patch nothing below the scissors > is included in the patch description. Welp, this seems to be due to a combination of me forgetting to add it, b4 adding it below the scissors automatically and then failing to warn about the missing sign-off. I'll resend v2 with your tags. And will also remove the Cc: stable as per net rules. Thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL 2024-09-16 18:54 ` Thomas Weißschuh @ 2024-09-16 19:04 ` Simon Horman 2024-09-16 19:05 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2024-09-16 19:04 UTC (permalink / raw) To: Thomas Weißschuh Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexander Aring, netdev, linux-kernel, stable On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote: > On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote: > > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote: > > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote: > > > > The rpl sr tunnel code contains calls to dst_cache_*() which are > > > > only present when the dst cache is built. > > > > Select DST_CACHE to build the dst cache, similar to other kconfig > > > > options in the same file. > > > > > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel") > > > > Cc: stable@vger.kernel.org > > > > --- > > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> > > > > > > Reviewed-by: Simon Horman <horms@kernel.org> > > > Tested-by: Simon Horman <horms@kernel.org> # build-tested > > > > Sorry Thomas, I missed one important thing: > > > > Your Signed-off-by line needs to go above the scissors ('---') > > because when git applies your patch nothing below the scissors > > is included in the patch description. > > Welp, this seems to be due to a combination of me forgetting to add it, > b4 adding it below the scissors automatically and then failing to warn > about the missing sign-off. > > I'll resend v2 with your tags. And will also remove the Cc: stable as > per net rules. Thanks. Please be aware of the 24h rule. https://docs.kernel.org/process/maintainer-netdev.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL 2024-09-16 19:04 ` Simon Horman @ 2024-09-16 19:05 ` Simon Horman 0 siblings, 0 replies; 6+ messages in thread From: Simon Horman @ 2024-09-16 19:05 UTC (permalink / raw) To: Thomas Weißschuh Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexander Aring, netdev, linux-kernel, stable On Mon, Sep 16, 2024 at 08:04:16PM +0100, Simon Horman wrote: > On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote: > > On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote: > > > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote: > > > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote: > > > > > The rpl sr tunnel code contains calls to dst_cache_*() which are > > > > > only present when the dst cache is built. > > > > > Select DST_CACHE to build the dst cache, similar to other kconfig > > > > > options in the same file. > > > > > > > > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel") > > > > > Cc: stable@vger.kernel.org > > > > > --- > > > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> > > > > > > > > Reviewed-by: Simon Horman <horms@kernel.org> > > > > Tested-by: Simon Horman <horms@kernel.org> # build-tested > > > > > > Sorry Thomas, I missed one important thing: > > > > > > Your Signed-off-by line needs to go above the scissors ('---') > > > because when git applies your patch nothing below the scissors > > > is included in the patch description. > > > > Welp, this seems to be due to a combination of me forgetting to add it, > > b4 adding it below the scissors automatically and then failing to warn > > about the missing sign-off. BTW, if b4 is adding it then, maybe, you need to remove it from the cover letter using b4 prep --edit-cover > > > > I'll resend v2 with your tags. And will also remove the Cc: stable as > > per net rules. > > Thanks. Please be aware of the 24h rule. > > https://docs.kernel.org/process/maintainer-netdev.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-16 19:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-16 16:53 [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL Thomas Weißschuh 2024-09-16 18:44 ` Simon Horman 2024-09-16 18:48 ` Simon Horman 2024-09-16 18:54 ` Thomas Weißschuh 2024-09-16 19:04 ` Simon Horman 2024-09-16 19:05 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox