From: Christian Brauner <brauner@kernel.org>
To: Julian Sun <sunjunchao2870@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
viro@zeniv.linux.org.uk, jack@suse.cz, stable@vger.kernel.org,
syzbot+296b1c84b9cbf306e5a0@syzkaller.appspotmail.com,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] vfs: Fix implicit conversion problem when testing overflow case
Date: Wed, 25 Sep 2024 10:36:51 +0200 [thread overview]
Message-ID: <20240925-gewillt-bankintern-0fd0ba5bca82@brauner> (raw)
In-Reply-To: <20240920122851.215641-1-sunjunchao2870@gmail.com>
On Fri, 20 Sep 2024 20:28:51 +0800, Julian Sun wrote:
> The overflow check in generic_copy_file_checks() and generic_remap_checks()
> is now broken because the result of the addition is implicitly converted to
> an unsigned type, which disrupts the comparison with signed numbers.
> This caused the kernel to not return EOVERFLOW in copy_file_range()
> call with len is set to 0xffffffffa003e45bul.
>
> Use the check_add_overflow() macro to fix this issue.
>
> [...]
Applied to the vfs.misc.v6.13 branch of the vfs/vfs.git tree.
Patches in the vfs.misc.v6.13 branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc.v6.13
[2/3] vfs: Fix implicit conversion problem when testing overflow case
https://git.kernel.org/vfs/vfs/c/8f3ab2511887
next prev parent reply other threads:[~2024-09-25 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 12:28 [PATCH 2/3] vfs: Fix implicit conversion problem when testing overflow case Julian Sun
2024-09-20 12:30 ` kernel test robot
2024-09-20 14:17 ` Christoph Hellwig
2024-09-20 14:38 ` Darrick J. Wong
2024-09-25 8:36 ` Christian Brauner [this message]
2025-01-06 8:35 ` Julian Sun
2024-09-25 8:37 ` Christian Brauner
2024-09-26 9:06 ` Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925-gewillt-bankintern-0fd0ba5bca82@brauner \
--to=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=syzbot+296b1c84b9cbf306e5a0@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox