From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0CDA184538; Wed, 25 Sep 2024 11:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727265021; cv=none; b=EF6edmaXGnpsk043t/0URzMV4ilNokj77Esfknydn0DBBzL0N7rky0IlircNi/poT6tdNPvrallERMM5xrJD2jhFwngQEd+pm+QtffrzS2QMCUKmVTKIPQ9EhmRz2ekMoo3DYT7IUWTAir3SpPkxrYEFVWwI1GiR2YmK679Jtcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727265021; c=relaxed/simple; bh=ORA76I4VbywASKgwmUaT2DVqaDGu/gExIJzUOFwg13g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c3rJaVmrjrW0srZ34FXDvEDgy4h4+0F+XICpF7n4aOP9YOFf2b/bbwLl8eK1eFftfXDSCN65YWZMRCkQ5h6RN5Ym4D0mXNlMfBhBgWZ/CgU8k3kiCw5Hc3giiHLpFzvLfTVgwfyUB4uoWXbHu0W0CLEhwIL9oJDxBbIQo4kTcKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p8xV0SMZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p8xV0SMZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E665C4CEC7; Wed, 25 Sep 2024 11:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727265020; bh=ORA76I4VbywASKgwmUaT2DVqaDGu/gExIJzUOFwg13g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8xV0SMZYtoAnnWvfIcoomzPRtmkpN4AeJnstQqV/yn8+widRLnKrmirlA5XafdWm O+Nf4p41SNT8ttG/nBkCAzcCLjeSB6ziPPR2jsRciyOx8CpQQwL9aF4tXy6XdKtu0k jjW1V33iZpF7xfINcp9d59wZTBbhyYhnkoEC63YgjTmt+R6NuytVGzxZeXTqigi5Tz nkCepwgC1H00y1jTaghiAE8YA4CcUWI6uUiXNQml95m/cfKkqrqZ4Rc4O6s6+ipakd V78V7z9YiNJvuQ++2K/HiaHFNGIpmRwaCWq1s+Mm06hpKJjAGwEK0KeIYFLErOm5NM 5vHa9JF+jJckA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Aurabindo Pillai , Daniel Wheeler , Rodrigo Siqueira , Alex Deucher , Sasha Levin , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, ivlipski@amd.com, hamza.mahfooz@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.11 195/244] drm/amd/display: Initialize get_bytes_per_element's default to 1 Date: Wed, 25 Sep 2024 07:26:56 -0400 Message-ID: <20240925113641.1297102-195-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925113641.1297102-1-sashal@kernel.org> References: <20240925113641.1297102-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.11 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit 4067f4fa0423a89fb19a30b57231b384d77d2610 ] Variables, used as denominators and maybe not assigned to other values, should not be 0. bytes_per_element_y & bytes_per_element_c are initialized by get_bytes_per_element() which should never return 0. This fixes 10 DIVIDE_BY_ZERO issues reported by Coverity. Signed-off-by: Alex Hung Reviewed-by: Aurabindo Pillai Tested-by: Daniel Wheeler Signed-off-by: Rodrigo Siqueira Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 2 +- .../gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c index 3d95bfa5aca23..ae52510417280 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c @@ -78,7 +78,7 @@ static void calculate_ttu_cursor(struct display_mode_lib *mode_lib, static unsigned int get_bytes_per_element(enum source_format_class source_format, bool is_chroma) { - unsigned int ret_val = 0; + unsigned int ret_val = 1; if (source_format == dm_444_16) { if (!is_chroma) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c index 98502a4f05672..9e1c18b90805d 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c @@ -53,7 +53,7 @@ static void calculate_ttu_cursor( static unsigned int get_bytes_per_element(enum source_format_class source_format, bool is_chroma) { - unsigned int ret_val = 0; + unsigned int ret_val = 1; if (source_format == dm_444_16) { if (!is_chroma) -- 2.43.0