public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: rafael@kernel.org, akpm@linux-foundation.org,
	thunder.leizhen@huawei.com, wangweiyang2@huawei.com,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH -next 1/2] kobject: fix memory leak in kset_register() due to uninitialized kset->kobj.ktype
Date: Wed, 25 Sep 2024 14:19:12 +0200	[thread overview]
Message-ID: <2024092530-putt-democracy-e2df@gregkh> (raw)
In-Reply-To: <20240925120747.1930709-2-cuigaosheng1@huawei.com>

On Wed, Sep 25, 2024 at 08:07:46PM +0800, Gaosheng Cui wrote:
> If a kset with uninitialized kset->kobj.ktype be registered,

Does that happen today with any in-kernel code?  If so, let's fix those
kset instances, right?

> kset_register() will return error, and the kset.kobj.name allocated
> by kobject_set_name() will be leaked.
> 
> To mitigate this, we free the name in kset_register() when an error
> is encountered due to uninitialized kset->kobj.ktype.

How did you hit this?

thanks,

greg k-h

  parent reply	other threads:[~2024-09-25 12:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 12:07 [PATCH -next 0/2] Fix memory leaks for kobject Gaosheng Cui
2024-09-25 12:07 ` [PATCH -next 1/2] kobject: fix memory leak in kset_register() due to uninitialized kset->kobj.ktype Gaosheng Cui
2024-09-25 12:18   ` Greg KH
2024-09-25 12:19   ` Greg KH [this message]
     [not found]     ` <c928dc7c-3418-d6cb-9503-e0c9a48adc1c@huawei.com>
2024-09-26  8:17       ` Greg KH
2024-09-25 12:07 ` [PATCH -next 2/2] kobject: fix memory leak when kobject_add_varg() returns error Gaosheng Cui
2024-09-25 12:18   ` Greg KH
2024-09-25 13:25   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024092530-putt-democracy-e2df@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=cuigaosheng1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    --cc=wangweiyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox