From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4898E1991B1 for ; Mon, 30 Sep 2024 18:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719984; cv=none; b=TOzAPFKumAd1l4NkfEHNEPUend/vzb7zbYNjETqDD9oE9PKRVAnIsIhg8GKyOLR4xGIhbWDJWZSMa2Dzgcfc0zyBMPz9Rlob+wx8hmXQkDEexi0L+6LaEBCZ00xocCt/LIYizujqrt1HD9YUgnNJpMrz8KbpogJKun345/UnZ9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719984; c=relaxed/simple; bh=MwpHU1aOR0WfimfF8hwtKOZhLVLHjAgYuri/pRu+Y2Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hpS4awmWil1g/rzcARd5vDDq3DV96pwDrflfnuzw/+RgAeAkh1oKKdol9GaJVQwe7YGZwpIVNB8u3C4r1PvIFSX/PO8HSqTU8xnDlMelNzCh0THyyOCcoGRf2NF6HI3Zo+nd6tV8gEDTdTOpAi/Of21K3CkyqCm4WdQBFZ/aihs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=umNcedll; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="umNcedll" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7a9a3e731f9so420747785a.0 for ; Mon, 30 Sep 2024 11:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1727719982; x=1728324782; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bdALx6XGSg/fJg5fRcCHzFiKUWFcvnMkCefk+ccFZhQ=; b=umNcedllilUFuUlvh2MXJ5i8nlY8Xz/Ax8iCBpbHlGMeHdXVWw4YIW/7pDcYrk9RPk X7yMBzqmFx/jeQU9akhFJTbZpQzZaSo3DcpdA2nPHu0TgF/EL/cmqh/sYejg2BfeUqpA o+Ae4AxyBq0NEDv0j7/KvzU8Tsvs70krJmrKp/jYfAySwNpfS11cf1twofbDsZwUDcqH aD2ONGwCqef+jQeNBm+0z7hqvT1D3xd11wc9ogcnsmrLI0ZWYdsS9SgNz5s31HUvwPr+ vQsI23ndBjVh29iO3vIMJUK1dZoTdFknefWvNlf07iSbIpxMOGB/V9Bw7PE1yKwkplj8 ds+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727719982; x=1728324782; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bdALx6XGSg/fJg5fRcCHzFiKUWFcvnMkCefk+ccFZhQ=; b=q+/FrKRxAtlQTI1CBEppO55GLw03qRykkTmhjRmvmM0X5liGFi040FFK8n2jYPHOgj 42BtC4QPwafnje16BXzUMFbzH1bmC4e4WmWTfq34Wn3agdR152KHBUOJGj8R1607YqFt flKSB33I+svPEVgtKBLgKp2AV5MIW6qF1ETFnj1am37BOsTjICXhG0wB7wrEN5wrMq8N Ojh/FNVx6lI8hci0pTI9TmAjxgDmNyk+adEwjWiH/kx9Oe8p6Mpw7tEWgWF18NqX8+oL 2uZllY5osLy7EOri+Z3EB5KwodpJPESnvIsHu0qbmWuqTwY1gR2s3niT7iTQmBIsepaz YArg== X-Forwarded-Encrypted: i=1; AJvYcCXCu/QCBm/OX8VaPr3l67ToUXXZNdQF3LQr3IDyCc3rqoYn0lUYUsD/XM/iscApcZEHqrqMSn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy04WtbcNv0ciIZgupy8yvxU1fbUs2FjCriU3Cfj9g8jv6yKZpI BfJ98wDPLbkazjKZ3TXaAY05E7LX4JN0K4J7fIYgGqwWwoQUNGxYypaabAJCbGQ= X-Google-Smtp-Source: AGHT+IFr76puGmRm668E/wAFDh1BfXsEVxvgieZu9NsMRTlQ7+ft2Y8FTRu64vMkd5Dc1ZbuGKR+sA== X-Received: by 2002:a05:620a:4093:b0:7a1:e2d4:4ff3 with SMTP id af79cd13be357-7ae378259e3mr2428718885a.3.1727719982233; Mon, 30 Sep 2024 11:13:02 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f2b6c96sm38192451cf.25.2024.09.30.11.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 11:13:01 -0700 (PDT) Date: Mon, 30 Sep 2024 14:13:00 -0400 From: Josef Bacik To: Christian Brauner Cc: Jeff Layton , Alexander Mikhalitsyn , linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] pidfs: check for valid pid namespace Message-ID: <20240930181300.GE667556@perftesting> References: <20240926-klebt-altgedienten-0415ad4d273c@brauner> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240926-klebt-altgedienten-0415ad4d273c@brauner> On Thu, Sep 26, 2024 at 06:51:46PM +0200, Christian Brauner wrote: > When we access a no-current task's pid namespace we need check that the > task hasn't been reaped in the meantime and it's pid namespace isn't > accessible anymore. > > The user namespace is fine because it is only released when the last > reference to struct task_struct is put and exit_creds() is called. > > Fixes: 5b08bd408534 ("pidfs: allow retrieval of namespace file descriptors") > CC: stable@vger.kernel.org # v6.11 > Signed-off-by: Christian Brauner Reviewed-by: Josef Bacik Thanks, Josef