From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B5529A1 for ; Tue, 1 Oct 2024 08:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727769992; cv=none; b=AqIisu4Ko9s60sJneBenpOFWRLmeVXj157mRyYXsNugwShEBw74Riv/j+gVh8WedLlw3hvAht8xEPxzpba5zP4BehlZrHKA2W1qN5ab4FCmiawn883jnhjQ5JX/nrcQa7CQJ2LmUMTZCnjGSqRI5XCATpnUgVSLjW0utECVwpjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727769992; c=relaxed/simple; bh=QA4X3VFLvAi3+SvsieLATQWEJOCWS4gatE4bPKf4oUU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mWbH6Bf7fOJeBVbSNUpO8gkr1uMP7vw8DeOSSJVgJht3gIYjEA/hToTMDSmwB0/D4mIXU7AgWDVjuOHkRYPjjzZo0AA6V1vLSiWghLXGH0c6CrEAYYShazUc2ocg2yAV/+PcOtIfps6HSHR0OGSnPheixtSHMNBRgRa7Lvf9XaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vcgkJZBL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vcgkJZBL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2887C4CEC6; Tue, 1 Oct 2024 08:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727769991; bh=QA4X3VFLvAi3+SvsieLATQWEJOCWS4gatE4bPKf4oUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vcgkJZBLGjfIyekX/h3lH2Zd6Sj/L/cmC+2cQIQ/BBUBk+ZF0MvKlWHhb7HocyP2k JA3rn2dWdG9bvI01ADxHcbz5w+QJexWT8S0MR51FWQmWt9MWoTa5qqC1+zSMg93lp2 5iGaxA3lqVKR35iSqqCX3do/XWJBFIksmWTrHZNw= Date: Tue, 1 Oct 2024 10:06:28 +0200 From: Greg KH To: Ricardo Neri Cc: stable@vger.kernel.org, x86@kernel.org, Tony Luck , Pawan Kumar Gupta , Zhang Rui , "Rafael J. Wysocki" , Sumeet Pawnikar , Thomas Lindroth , Hans de Goede , Bastien Nocera , Dmitry Torokhov , Ricardo Neri Subject: Re: [PATCH 5.10.y 0/3] x86: Complete backports for x86_match_cpu() Message-ID: <2024100115-pessimism-mayday-cbd9@gregkh> References: <20240928162431.22129-1-ricardo.neri-calderon@linux.intel.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928162431.22129-1-ricardo.neri-calderon@linux.intel.com> On Sat, Sep 28, 2024 at 09:24:28AM -0700, Ricardo Neri wrote: > Hi, > > Upstream commit 93022482b294 ("x86/cpu: Fix x86_match_cpu() to match just > X86_VENDOR_INTEL") introduced a flags member to struct x86_cpu_id. Bit 0 > of x86_cpu.id.flags must be set to 1 for x86_match_cpu() to work correctly. > This upstream commit has been backported to 5.10.y. > > Callers that use the X86_MATCH_*() family of macros to compose the argument > of x86_match_cpu() function correctly. Callers that use their own custom > mechanisms may not work if they fail to set x86_cpu_id.flags correctly. > > There are three remaining callers in 5.10.y that use their own mechanisms: > a) setup_pcid(), b) rapl_msr_probe(), and c) goodix_add_acpi_gpio_ > mappings(). a) caused a regression that Thomas Lindroth reported in [1]. b) > works by luck but it still populates its x86_cpu_id[] array incorrectly. I > am not aware of any reports on c), but inspecting the code reveals that it > will fail to identify INTEL_FAM6_ATOM_SILVERMONT for the reason described > above. > > I backported three patches that fix these bugs in mainline. Hopefully the > authors and/or maintainers can ack the backports? > > I tested patches 2/3 and 3/3 on Tiger Lake, Alder Lake, and Meteor Lake > systems as the two involved callers behave differently on these systems. > I wrote the testing details in each patch separately. I could not test > patch 1/3 because I do not have access to Bay Trail hardware. This and the 5.15 series now queued up, thanks. greg k-h