From: Greg KH <gregkh@linuxfoundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
ruanjinjie@huawei.com
Subject: Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
Date: Tue, 1 Oct 2024 11:32:16 +0200 [thread overview]
Message-ID: <2024100134-talcum-angular-6e20@gregkh> (raw)
In-Reply-To: <Zvu8GiY4PxqTQPD0@google.com>
On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> >
> > to the 5.15-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > and it can be found in the queue-5.15 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
>
> For the love of God, why? Why does this pure cleanup type of change
> needs to be in stable?
Because someone said:
> > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > Date: Thu Sep 12 11:30:13 2024 +0800
> >
> > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> >
> > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> >
> > disable_irq() after request_irq() still has a time gap in which
> > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > disable IRQ auto-enable when request IRQ.
Looks like a bug fix, and also:
> > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
Someone marked it as such.
I'll go drop it, but really, don't mark things as fixes if they really
are not.
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-01 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241001002900.2628013-1-sashal@kernel.org>
2024-10-01 9:08 ` Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree Dmitry Torokhov
2024-10-01 9:32 ` Greg KH [this message]
2024-10-01 10:00 ` Dmitry Torokhov
2024-10-01 10:05 ` Greg KH
2024-10-01 10:47 ` Dmitry Torokhov
2024-10-01 11:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024100134-talcum-angular-6e20@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox