* [PATCH 1/2] firmware: qcom: scm: suppress download mode error
[not found] <20241002100122.18809-1-johan+linaro@kernel.org>
@ 2024-10-02 10:01 ` Johan Hovold
2024-10-04 21:49 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2024-10-02 10:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mukesh Ojha,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable
Stop spamming the logs with errors about missing mechanism for setting
the so called download (or dump) mode for users that have not requested
that feature to be enabled in the first place.
This avoids the follow error being logged on boot as well as on
shutdown when the feature it not available and download mode has not
been enabled on the kernel command line:
qcom_scm firmware:scm: No available mechanism for setting download mode
Fixes: 79cb2cb8d89b ("firmware: qcom: scm: Disable SDI and write no dump to dump mode")
Fixes: 781d32d1c970 ("firmware: qcom_scm: Clear download bit during reboot")
Cc: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: stable@vger.kernel.org # 6.4
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/firmware/qcom/qcom_scm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 10986cb11ec0..e2ac595902ed 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -545,7 +545,7 @@ static void qcom_scm_set_download_mode(u32 dload_mode)
} else if (__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_BOOT,
QCOM_SCM_BOOT_SET_DLOAD_MODE)) {
ret = __qcom_scm_set_dload_mode(__scm->dev, !!dload_mode);
- } else {
+ } else if (dload_mode) {
dev_err(__scm->dev,
"No available mechanism for setting download mode\n");
}
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] firmware: qcom: scm: suppress download mode error
2024-10-02 10:01 ` [PATCH 1/2] firmware: qcom: scm: suppress download mode error Johan Hovold
@ 2024-10-04 21:49 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2024-10-04 21:49 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel, stable
On Wed, Oct 02, 2024 at 12:01:21PM +0200, Johan Hovold wrote:
> Stop spamming the logs with errors about missing mechanism for setting
> the so called download (or dump) mode for users that have not requested
> that feature to be enabled in the first place.
>
> This avoids the follow error being logged on boot as well as on
> shutdown when the feature it not available and download mode has not
> been enabled on the kernel command line:
>
> qcom_scm firmware:scm: No available mechanism for setting download mode
>
> Fixes: 79cb2cb8d89b ("firmware: qcom: scm: Disable SDI and write no dump to dump mode")
> Fixes: 781d32d1c970 ("firmware: qcom_scm: Clear download bit during reboot")
> Cc: Mukesh Ojha <quic_mojha@quicinc.com>
> Cc: stable@vger.kernel.org # 6.4
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241002100122.18809-1-johan+linaro@kernel.org>
2024-10-02 10:01 ` [PATCH 1/2] firmware: qcom: scm: suppress download mode error Johan Hovold
2024-10-04 21:49 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox