From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF0731474BC; Wed, 2 Oct 2024 14:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727879969; cv=none; b=SpDAylu+vBAd6Zzf0cSUNSRJR5jvTWbgGVFJpMwDVrdNA0mapsFacqFkeu07tXWCh5JsztCswq46JfblXnPOX7LKxnlTFOVa2pJycS6fwXHG3j2Yem6O/Kj+0wI7t4Is0q3Uv0AyBgbXgf8nNBzs9pgDA1VX2dWXQSv3Pg/r8Mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727879969; c=relaxed/simple; bh=eLrUp+KzKG5d1hJgcjuL0RAd6+ORZGOSXjPVfZHSieU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=deWhSZlR/1UVUUMqVlrYURpZpB3fBCfLOoqYczNyRFn0vxUzx4vUXJ4idxwPuM0GMSpKM8BSSi30zkzMR/BTANCCRpD6e03MP16U1jN6VKCIaI/nnz1ZaAEeq2Gkcx50y4EyzE6nmIQFU9SqE7NSIrDMlD+jHhoCPKgRstz/NdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XPjo6yCi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XPjo6yCi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 761D1C4CEC2; Wed, 2 Oct 2024 14:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727879968; bh=eLrUp+KzKG5d1hJgcjuL0RAd6+ORZGOSXjPVfZHSieU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XPjo6yCil7ZC94FGG8JdHm46NMaCRqzjDx+Z42KnsQqwsgYJAbt4p4FcSxFjON52l 2VgsXtKjqoHG59vdllPeh9NKNs02yUwIiTWBFgd71MFrtmdh8WLIY9MArQM4fEPQ6+ UB3rwYURrOjfDwDxpYeb6ky2oqxoF81mhMYVzxNM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peng Fan , Daniel Baluta , Mathieu Poirier , Sasha Levin Subject: [PATCH 6.6 268/538] remoteproc: imx_rproc: Initialize workqueue earlier Date: Wed, 2 Oct 2024 14:58:27 +0200 Message-ID: <20241002125802.835977063@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241002125751.964700919@linuxfoundation.org> References: <20241002125751.964700919@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peng Fan [ Upstream commit 858e57c1d3dd7b92cc0fa692ba130a0a5d57e49d ] Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta Link: https://lore.kernel.org/r/20240719-imx_rproc-v2-3-10d0268c7eb1@nxp.com Signed-off-by: Mathieu Poirier Signed-off-by: Sasha Levin --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index ac32b46b4e0f8..d68d4b22f528e 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -1134,6 +1134,8 @@ static int imx_rproc_probe(struct platform_device *pdev) goto err_put_rproc; } + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); + ret = imx_rproc_xtr_mbox_init(rproc); if (ret) goto err_put_wkq; @@ -1152,8 +1154,6 @@ static int imx_rproc_probe(struct platform_device *pdev) if (ret) goto err_put_scu; - INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); - if (rproc->state != RPROC_DETACHED) rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); -- 2.43.0