From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA401D0957; Wed, 2 Oct 2024 14:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727877808; cv=none; b=oTcLUOhr2sNPS4MKlmVclLwtzTbsJGacCc0QISsKA/B3VP4WxEzwDQo7yxiKyA0bV1WDFw8i0mHFqIwP2ia6ZWq9FE3UNnQrbG78HXTIxeS1rbQJ2FMzeRChfwILPay0i79c5JcynKefrQfPEx5d7YBOuQC1JXh40xEmSCQieh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727877808; c=relaxed/simple; bh=VrlQGIoDRX9hfNNglen4GROOUYMslZFqvQELuD4g284=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cEwXMfx2sFhOwlgsduic/0ASONwBf0nsl2IzH5ZwRZbD19qSkGfD/ulHnNOBSx50nTUBwJ6mrjIWElX+AwMy93Uxs+QeJfpk6a3r1t3MYehWLlfFaZcYX+AMhqcyG3O5ljJdvYL92Msn6FQGkvod8fi62s1HhcRWVHr7cqEgmyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CYg3xIra; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CYg3xIra" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1642BC4CEC2; Wed, 2 Oct 2024 14:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727877808; bh=VrlQGIoDRX9hfNNglen4GROOUYMslZFqvQELuD4g284=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CYg3xIra5EH380JJDcZqNmxp9gOHVX2TkduRKP1PbDG3isLqGEJbJfuQ5cO6gYRAW NCCrLk/n6DQJ5Fq77UHIBaFLCWfMbFMo3iszQwkFEeI0NjIcpSOPm3CClngY+58ugE 0lcbv0cvvCeBrnCoyY8+A2Y7ftvPVda4sbkMJLDk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Charles Han , Miquel Raynal , Sasha Levin Subject: [PATCH 6.10 170/634] mtd: powernv: Add check devm_kasprintf() returned value Date: Wed, 2 Oct 2024 14:54:30 +0200 Message-ID: <20241002125817.820622949@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241002125811.070689334@linuxfoundation.org> References: <20241002125811.070689334@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Charles Han [ Upstream commit 395999829880a106bb95f0ce34e6e4c2b43c6a5d ] devm_kasprintf() can return a NULL pointer on failure but this returned value is not checked. Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name") Signed-off-by: Charles Han Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20240828092427.128177-1-hanchunchao@inspur.com Signed-off-by: Sasha Levin --- drivers/mtd/devices/powernv_flash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 66044f4f5bade..10cd1d9b48859 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -207,6 +207,9 @@ static int powernv_flash_set_driver_info(struct device *dev, * get them */ mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFP", dev->of_node); + if (!mtd->name) + return -ENOMEM; + mtd->type = MTD_NORFLASH; mtd->flags = MTD_WRITEABLE; mtd->size = size; -- 2.43.0