From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458DB1D079B; Wed, 2 Oct 2024 14:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727878423; cv=none; b=CPp9YQe/8aF62/1IM5dRs4xDExnZjdHik0jJp3Vz4CXpUyLCB04SWLg2vR/AEVZOTz/+WBSHcLAVuJP2jlIr3o4A0txWmFNy5uqZRtbtM6AMJcDft69eZvrku7zkaM3vKeUcqlEdgMCsiDIj3HTrGXfkc7UOS5ns85d2LwSeXeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727878423; c=relaxed/simple; bh=D+VVu/hG9GC6anKsCS8I2llsjZFzvVTUoVxE3G9HSzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Blr2YYXFCaF4BhBF6rTA1qTnyaT1/e7MkBeFrjZwUlVxIDPHtEfwOdUCWeQoAtGh416aGF2Sow0BOrM1IQ1up7xPlUW0EiPM4dIcPgVygIfuf7n8omRcn4DmJAy69IYKsUVklKvAmOYMLt+o62uXJJJT0ApRUHAfyGIaktshYdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cBTR9RCh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cBTR9RCh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C51D4C4CEC2; Wed, 2 Oct 2024 14:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1727878423; bh=D+VVu/hG9GC6anKsCS8I2llsjZFzvVTUoVxE3G9HSzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cBTR9RChWJLSZym8bs5j/mdwuggmqelSLo+AzbhVppe2YjYsx12hyjbv9TnWZAxpK PQxh4BH+bFYctCZYPacq25FNPUUWkhj2AYRdor73ehL5kfQIUcrokVe7otuW16OAjD kW8gCglIHsT6bDXrxE+djgaMVOv5/kP+7wXDHbPM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Junxian Huang , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.10 377/634] RDMA/hns: Fix VF triggering PF reset in abnormal interrupt handler Date: Wed, 2 Oct 2024 14:57:57 +0200 Message-ID: <20241002125825.978887794@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241002125811.070689334@linuxfoundation.org> References: <20241002125811.070689334@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junxian Huang [ Upstream commit 4321feefa5501a746ebf6a7d8b59e6b955ae1860 ] In abnormal interrupt handler, a PF reset will be triggered even if the device is a VF. It should be a VF reset. Fixes: 2b9acb9a97fe ("RDMA/hns: Add the process of AEQ overflow for hip08") Signed-off-by: Junxian Huang Link: https://patch.msgid.link/20240906093444.3571619-7-huangjunxian6@hisilicon.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 2225c9cc63661..5483d04b3ab7e 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -6198,6 +6198,7 @@ static irqreturn_t abnormal_interrupt_basic(struct hns_roce_dev *hr_dev, struct pci_dev *pdev = hr_dev->pci_dev; struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev); const struct hnae3_ae_ops *ops = ae_dev->ops; + enum hnae3_reset_type reset_type; irqreturn_t int_work = IRQ_NONE; u32 int_en; @@ -6209,10 +6210,12 @@ static irqreturn_t abnormal_interrupt_basic(struct hns_roce_dev *hr_dev, roce_write(hr_dev, ROCEE_VF_ABN_INT_ST_REG, 1 << HNS_ROCE_V2_VF_INT_ST_AEQ_OVERFLOW_S); + reset_type = hr_dev->is_vf ? + HNAE3_VF_FUNC_RESET : HNAE3_FUNC_RESET; + /* Set reset level for reset_event() */ if (ops->set_default_reset_request) - ops->set_default_reset_request(ae_dev, - HNAE3_FUNC_RESET); + ops->set_default_reset_request(ae_dev, reset_type); if (ops->reset_event) ops->reset_event(pdev, NULL); -- 2.43.0