public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Sasha Levin <sashal@kernel.org>,
	mturquette@baylibre.com, linux-clk@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 23/58] clk: bcm: bcm53573: fix OF node leak in init
Date: Fri,  4 Oct 2024 14:23:56 -0400	[thread overview]
Message-ID: <20241004182503.3672477-23-sashal@kernel.org> (raw)
In-Reply-To: <20241004182503.3672477-1-sashal@kernel.org>

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[ Upstream commit f92d67e23b8caa81f6322a2bad1d633b00ca000e ]

Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
leak by accessing parent directly, instead of of_get_parent().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clk/bcm/clk-bcm53573-ilp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-bcm53573-ilp.c b/drivers/clk/bcm/clk-bcm53573-ilp.c
index 84f2af736ee8a..83ef41d618be3 100644
--- a/drivers/clk/bcm/clk-bcm53573-ilp.c
+++ b/drivers/clk/bcm/clk-bcm53573-ilp.c
@@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np)
 		goto err_free_ilp;
 	}
 
-	ilp->regmap = syscon_node_to_regmap(of_get_parent(np));
+	ilp->regmap = syscon_node_to_regmap(np->parent);
 	if (IS_ERR(ilp->regmap)) {
 		err = PTR_ERR(ilp->regmap);
 		goto err_free_ilp;
-- 
2.43.0


  parent reply	other threads:[~2024-10-04 18:25 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 18:23 [PATCH AUTOSEL 6.6 01/58] selftests/bpf: Fix ARG_PTR_TO_LONG {half-,}uninitialized test Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 02/58] bpf: Check percpu map value size first Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 03/58] bpftool: Fix undefined behavior in qsort(NULL, 0, ...) Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 04/58] bpftool: Fix undefined behavior caused by shifting into the sign bit Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 05/58] s390/boot: Compile all files with the same march flag Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 06/58] s390/facility: Disable compile time optimization for decompressor code Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 07/58] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 08/58] bpf, x64: Fix a jit convergence issue Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 09/58] ext4: fix i_data_sem unlock order in ext4_ind_migrate() Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 10/58] ext4: avoid use-after-free in ext4_ext_show_leaf() Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 11/58] ext4: ext4_search_dir should return a proper error Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 12/58] iomap: fix iomap_dio_zero() for fs bs > system page size Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 13/58] ext4: don't set SB_RDONLY after filesystem errors Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 14/58] ext4: nested locking for xattr inode Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 15/58] s390/cpum_sf: Remove WARN_ON_ONCE statements Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 16/58] s390/traps: Handle early warnings gracefully Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 17/58] bpf: Prevent tail call between progs attached to different hooks Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 18/58] ktest.pl: Avoid false positives with grub2 skip regex Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 19/58] RDMA/mad: Improve handling of timed out WRs of mad agent Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 20/58] soundwire: intel_bus_common: enable interrupts before exiting reset Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 21/58] PCI: Add function 0 DMA alias quirk for Glenfly Arise chip Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 22/58] RDMA/rtrs-srv: Avoid null pointer deref during path establishment Sasha Levin
2024-10-04 18:23 ` Sasha Levin [this message]
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 24/58] PCI: Add ACS quirk for Qualcomm SA8775P Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 25/58] i2c: i801: Use a different adapter-name for IDF adapters Sasha Levin
2024-10-04 18:23 ` [PATCH AUTOSEL 6.6 26/58] PCI: Mark Creative Labs EMU20k2 INTx masking as broken Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 27/58] i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 28/58] RISC-V: Don't have MAX_PHYSMEM_BITS exceed phys_addr_t Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 29/58] io_uring: check if we need to reschedule during overflow flush Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 30/58] ntb: ntb_hw_switchtec: Fix use after free vulnerability in switchtec_ntb_remove due to race condition Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 31/58] mfd: intel_soc_pmic_chtwc: Make Lenovo Yoga Tab 3 X90F DMI match less strict Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 32/58] riscv: avoid Imbalance in RAS Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 33/58] RDMA/mlx5: Enforce umem boundaries for explicit ODP page faults Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 34/58] soundwire: cadence: re-check Peripheral status with delayed_work Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 35/58] riscv/kexec_file: Fix relocation type R_RISCV_ADD16 and R_RISCV_SUB16 unknown Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 36/58] media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put() Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 37/58] remoteproc: imx_rproc: Use imx specific hook for find_loaded_rsc_table Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 38/58] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 39/58] fuse: handle idmappings properly in ->write_iter() Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 40/58] serial: protect uart_port_dtr_rts() in uart_shutdown() too Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 41/58] usb: typec: tipd: Free IRQ only if it was requested before Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 42/58] usb: chipidea: udc: enable suspend interrupt after usb reset Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 43/58] usb: dwc2: Adjust the timing of USB Driver Interrupt Registration in the Crashkernel Scenario Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 44/58] comedi: ni_routing: tools: Check when the file could not be opened Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 45/58] LoongArch: Fix memleak in pci_acpi_scan_root() Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 46/58] netfilter: nf_nat: don't try nat source port reallocation for reverse dir clash Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 47/58] netfilter: nf_reject: Fix build warning when CONFIG_BRIDGE_NETFILTER=n Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 48/58] virtio_pmem: Check device status before requesting flush Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 49/58] tools/iio: Add memory allocation failure check for trigger_name Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 50/58] staging: vme_user: added bound check to geoid Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 51/58] driver core: bus: Fix double free in driver API bus_register() Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 52/58] driver core: bus: Return -EIO instead of 0 when show/store invalid bus attribute Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 53/58] scsi: lpfc: Add ELS_RSP cmd to the list of WQEs to flush in lpfc_els_flush_cmd() Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 54/58] scsi: lpfc: Ensure DA_ID handling completion before deleting an NPIV instance Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 55/58] drm/amd/display: Check null pointer before dereferencing se Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 56/58] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 57/58] smb: client: fix UAF in async decryption Sasha Levin
2024-10-04 18:24 ` [PATCH AUTOSEL 6.6 58/58] fbdev: sisfb: Fix strbuf array overflow Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004182503.3672477-23-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox