From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB0F91C9B99; Tue, 8 Oct 2024 13:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728392972; cv=none; b=ZmMsD5cEK2Qt7gcr/vIo3gqio0o2RM7V6QYcRneSzZ9LEcqIigXeU+Bf7dDrpnm2ylAn1/S4KZESKLhyaTIgORsaojJlmjNIMmlgA37ZjplrHJxa9cdlLxB+fXhJFYWMgjUtS9+C08rpqKzjkPGcKDgrSlPSisfj7RVGd1cB+68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728392972; c=relaxed/simple; bh=Pw+PDkLD+bLLqA6GKNbPpeAELzU8JZaNN9EsePp4g5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Os67t9lygKpWjjqABdaP+ilrXEw4pvGb8ICzjM21AnXOuA/YEnkBgFVcz/9NEFOLGY/1OkNxb4+aMK8PhjN3mqO05z0NIZX5aTn1KTC6Kr5wQWl9UmncIl9Q+IQ2C8nReXv3YX0ZDnkPXQctBL0oo6h4a6se2DxxI9VHXwx/q1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VLK/82EW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VLK/82EW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01BFDC4CEC7; Tue, 8 Oct 2024 13:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728392971; bh=Pw+PDkLD+bLLqA6GKNbPpeAELzU8JZaNN9EsePp4g5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VLK/82EWsDp+S2pklVjmZeNovQpC+8T5XRWPJRJwjeitkpXGACBDnJSPu+LuPepzB FZEQpqzGZkSdO6fjo6B56MMhifYps2cb2dm9W3SFU7c1SiOl7JwCcaswX43zEIkXj2 3CO8SQD+S+Mi+Ss9RVaEUK8XGFaZHogc++U9NK9E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Elena Salomatkina , Simon Horman , Kalesh AP , Tariq Toukan , Gal Pressman , Saeed Mahameed , Sasha Levin Subject: [PATCH 6.6 015/386] net/mlx5e: Fix NULL deref in mlx5e_tir_builder_alloc() Date: Tue, 8 Oct 2024 14:04:20 +0200 Message-ID: <20241008115629.922367277@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115629.309157387@linuxfoundation.org> References: <20241008115629.309157387@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Elena Salomatkina [ Upstream commit f25389e779500cf4a59ef9804534237841bce536 ] In mlx5e_tir_builder_alloc() kvzalloc() may return NULL which is dereferenced on the next line in a reference to the modify field. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a6696735d694 ("net/mlx5e: Convert TIR to a dedicated object") Signed-off-by: Elena Salomatkina Reviewed-by: Simon Horman Reviewed-by: Kalesh AP Reviewed-by: Tariq Toukan Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en/tir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c index d4239e3b3c88e..11f724ad90dbf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c @@ -23,6 +23,9 @@ struct mlx5e_tir_builder *mlx5e_tir_builder_alloc(bool modify) struct mlx5e_tir_builder *builder; builder = kvzalloc(sizeof(*builder), GFP_KERNEL); + if (!builder) + return NULL; + builder->modify = modify; return builder; -- 2.43.0