From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3301DD867; Tue, 8 Oct 2024 12:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389588; cv=none; b=nw4oZOrtHAXpNtUeQrwrF9dcFZiA89wCEtHSF7LaDYomWEw2LT6MaFO/AfxywQxI1Q4TTNy4Ay4UARwcNBbn4kDeY9GUcB4jKIDVDFsfYhEtOEuGUvh3MApNRJPCQNvidaQyo2plZzmfpdWXIlYte4UZr13FdfXNRZnHQmwMFpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389588; c=relaxed/simple; bh=pqhw2J8BHKcmH9nITdOrVXtpWK4t03/ZXU2u9cI0duw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YdVz/v/otM84BMbZnZ5uaQbF3EKdbhIcoZBtEyQ96qH/EzDo6CH9sYxOBKl+YmUYHVEWr2+s22aahiQ6lbO8BV8eyXEAjXqrauW7txbjC3ZoTiFaJSnp+JO+LxEL2ZHwHgTWZNZSxdhxnshuTkfOarhBGKzfbnLUqANuRxnwRYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yZeliX2N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yZeliX2N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BC5BC4CEC7; Tue, 8 Oct 2024 12:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728389587; bh=pqhw2J8BHKcmH9nITdOrVXtpWK4t03/ZXU2u9cI0duw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yZeliX2NGG5u9/z6dFXotdmvoh6whcI0NdNvquxtDdraqQEHBwQNpKCKTk/uuuuv6 s8tAns1+Rs33TQcYWt+cirlBYvrk+u3sEpdWgFT6C3SV9/tqppIgGZfEpWWoR0Aip9 WfoUAV671zWj5kz+mI8SCZONHbvdf28wItZTBwVI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Elena Salomatkina , Simon Horman , Kalesh AP , Tariq Toukan , Gal Pressman , Saeed Mahameed , Sasha Levin Subject: [PATCH 6.10 020/482] net/mlx5e: Fix NULL deref in mlx5e_tir_builder_alloc() Date: Tue, 8 Oct 2024 14:01:23 +0200 Message-ID: <20241008115649.094383468@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Elena Salomatkina [ Upstream commit f25389e779500cf4a59ef9804534237841bce536 ] In mlx5e_tir_builder_alloc() kvzalloc() may return NULL which is dereferenced on the next line in a reference to the modify field. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a6696735d694 ("net/mlx5e: Convert TIR to a dedicated object") Signed-off-by: Elena Salomatkina Reviewed-by: Simon Horman Reviewed-by: Kalesh AP Reviewed-by: Tariq Toukan Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en/tir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c index d4239e3b3c88e..11f724ad90dbf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c @@ -23,6 +23,9 @@ struct mlx5e_tir_builder *mlx5e_tir_builder_alloc(bool modify) struct mlx5e_tir_builder *builder; builder = kvzalloc(sizeof(*builder), GFP_KERNEL); + if (!builder) + return NULL; + builder->modify = modify; return builder; -- 2.43.0