From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64ADE1DA60C; Tue, 8 Oct 2024 12:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389629; cv=none; b=aTXbDG7ANM9eqmvEVvgw4UZHsDjwWOnRhwU7J21nYbUF+z7Pca9mD0oFMqbpWbL94QemrHN3H4I0ivEh6+Rge9c2kVmsn7V5Bx/l5dU9q4xlKnHjnTqmUUHvzWiYFE6MyUknqaVYJMaF7iRgeooqcm344R4dUfS61p2Ju66u1hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728389629; c=relaxed/simple; bh=mXSlST6x8Ntcg1xLT6deNwbXelIapYrf6LddvsKLy3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q3sUsO6FCKxAja++VA2zzJPQtUxZmWgl2D+wr8IIlBUeD4zn9Bt1tvuoerMZB6MxSpI9MpvRt2mNXljPxl31DctdbgON5W6TdovU6+QCXDG5LuYIrAjaHXIQ+HMiKrS8G6e9QS19EpIMrnR5PqQ4g4BTFKaZsd+SBhV3oCTY9Yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NQiPzRmN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NQiPzRmN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA430C4CEC7; Tue, 8 Oct 2024 12:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728389629; bh=mXSlST6x8Ntcg1xLT6deNwbXelIapYrf6LddvsKLy3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NQiPzRmN8oc1twBfSbYOtIdyMYnyV+huisBVbCSNmUJDCeuqWUOWzgmN5sZHnt7KB VplTwj6VJ430WZlj22k20PjU1NbE1+Lh6tTL+MUBZlpnkC1kmW7OXIJ4gFrSgyK9On w1xu1Wi7T1qav8C/fMGHC56SUGyINGFEaujh9SYo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ravikanth Tuniki , Radhey Shyam Pandey , Conor Dooley , Paolo Abeni , Sasha Levin Subject: [PATCH 6.10 048/482] dt-bindings: net: xlnx,axi-ethernet: Add missing reg minItems Date: Tue, 8 Oct 2024 14:01:51 +0200 Message-ID: <20241008115650.196335132@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ravikanth Tuniki [ Upstream commit c6929644c1e0d6108e57061d427eb966e1746351 ] Add missing reg minItems as based on current binding document only ethernet MAC IO space is a supported configuration. There is a bug in schema, current examples contain 64-bit addressing as well as 32-bit addressing. The schema validation does pass incidentally considering one 64-bit reg address as two 32-bit reg address entries. If we change axi_ethernet_eth1 example node reg addressing to 32-bit schema validation reports: Documentation/devicetree/bindings/net/xlnx,axi-ethernet.example.dtb: ethernet@40000000: reg: [[1073741824, 262144]] is too short To fix it add missing reg minItems constraints and to make things clearer stick to 32-bit addressing in examples. Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml") Signed-off-by: Ravikanth Tuniki Signed-off-by: Radhey Shyam Pandey Acked-by: Conor Dooley Link: https://patch.msgid.link/1727723615-2109795-1-git-send-email-radhey.shyam.pandey@amd.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml index bbe89ea9590ce..e95c216282818 100644 --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml @@ -34,6 +34,7 @@ properties: and length of the AXI DMA controller IO space, unless axistream-connected is specified, in which case the reg attribute of the node referenced by it is used. + minItems: 1 maxItems: 2 interrupts: @@ -181,7 +182,7 @@ examples: clock-names = "s_axi_lite_clk", "axis_clk", "ref_clk", "mgt_clk"; clocks = <&axi_clk>, <&axi_clk>, <&pl_enet_ref_clk>, <&mgt_clk>; phy-mode = "mii"; - reg = <0x00 0x40000000 0x00 0x40000>; + reg = <0x40000000 0x40000>; xlnx,rxcsum = <0x2>; xlnx,rxmem = <0x800>; xlnx,txcsum = <0x2>; -- 2.43.0