From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5DE41DACBE; Tue, 8 Oct 2024 12:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390073; cv=none; b=irvOgNhbY03I+EW67qN+dRtv2SLyamvce2hw6T+L4oqZkVBK/zitMW+BgedEhXr2uZ/gU3ahyxfQnpKB8QAlhz57lLx9JLkxEbhKp+ZEBPJ2M48Iw9OF9iIRNq++T41HXIBo6oJ1q5QRw4Sfmd8rmShB8vhXRxdi82KSyRWn+2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390073; c=relaxed/simple; bh=rWCl3hJ1xYDF3NXJtp6CpGtOpEmAq3DXehoE5Vwr4Ag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iXEptV0+j8TEiGvcTvSHkOpMgaid9smbJPRlTUDZt/027f/n1v+Yo9/ELfXf+VcxDFFch5hJDH6VfMwa4SUY71XvnspIzxmTxTh1LKUUvSILIbU7vYfwQbyS8S06NcWXCh+q8mU8TaoG797cI528+7l0+aJbeSfxgbSYARwmdqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KdkKh4Hb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KdkKh4Hb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08C45C4CEC7; Tue, 8 Oct 2024 12:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728390073; bh=rWCl3hJ1xYDF3NXJtp6CpGtOpEmAq3DXehoE5Vwr4Ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KdkKh4HbUWyYG0jLBQ9y7Q5ZZokN0TInpoDJV/BVpBqABJTWyT8qSsvSOVPlIRGq4 MdF5tGS5hDY4OlKunJ4N22CJ0a/2tSZQkbK6im2fDlKtRop0HoZtkI1shHM2MlNurk RfC9Xj0DTIR1vbmwxWjlFmFKhliTcuTz4wL0o7cA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Suraj Kandpal , Dnyaneshwar Bhadane , Sasha Levin Subject: [PATCH 6.10 182/482] drm/xe/hdcp: Check GSC structure validity Date: Tue, 8 Oct 2024 14:04:05 +0200 Message-ID: <20241008115655.466640270@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Suraj Kandpal [ Upstream commit b4224f6bae3801d589f815672ec62800a1501b0d ] Sometimes xe_gsc is not initialized when checked at HDCP capability check. Add gsc structure check to avoid null pointer error. Signed-off-by: Suraj Kandpal Reviewed-by: Dnyaneshwar Bhadane Link: https://patchwork.freedesktop.org/patch/msgid/20240722064451.3610512-4-suraj.kandpal@intel.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c index b3d3c065dd9d8..2f935771658e6 100644 --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c @@ -39,10 +39,14 @@ bool intel_hdcp_gsc_check_status(struct xe_device *xe) { struct xe_tile *tile = xe_device_get_root_tile(xe); struct xe_gt *gt = tile->media_gt; + struct xe_gsc *gsc = >->uc.gsc; bool ret = true; - if (!xe_uc_fw_is_enabled(>->uc.gsc.fw)) + if (!gsc && !xe_uc_fw_is_enabled(&gsc->fw)) { + drm_dbg_kms(&xe->drm, + "GSC Components not ready for HDCP2.x\n"); return false; + } xe_pm_runtime_get(xe); if (xe_force_wake_get(gt_to_fw(gt), XE_FW_GSC)) { @@ -52,7 +56,7 @@ bool intel_hdcp_gsc_check_status(struct xe_device *xe) goto out; } - if (!xe_gsc_proxy_init_done(>->uc.gsc)) + if (!xe_gsc_proxy_init_done(gsc)) ret = false; xe_force_wake_put(gt_to_fw(gt), XE_FW_GSC); -- 2.43.0