From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C58FF1E485; Tue, 8 Oct 2024 12:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390724; cv=none; b=OYau8FtbAZwtZCcVUqUQ3dM+i49j1CqFKEfa8KMmOhQcuH10xd6lyjJoSXdkjvtwkBRQocppmEQysF3Chfy8uLJbwQuDcDyR0Weemp0tq3+njPoCOXtA+KldCpCG8VW8zjzwkzNZZWwWQbsC81xWxeaZVn1ByrjZcNxx3Zt4Omw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390724; c=relaxed/simple; bh=MkEOyGJHElj8j7nK8pubEtFUByeAFfX2HLtmRurTnyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPgl5Kd1iv16Yx9uysfTxZq7IHrx+mEjkity3WH44Osmh89W55JLdqw83tjsp9o9Ok9oiS7+wipA2rz+F+JM4M9zWSvoOxEyzKHTRBBuUjuJ5dksAIkDKivvJhVL5qUZ2KjvAFDRBB05ocKKHZHDwpZdsqtrhatzL9yLSL3bYFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hz76xk6o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hz76xk6o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F99CC4CEC7; Tue, 8 Oct 2024 12:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728390724; bh=MkEOyGJHElj8j7nK8pubEtFUByeAFfX2HLtmRurTnyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hz76xk6oT5UZGq6TQtJC4ZFMsABZhWuLBff9EE3Vbncibgz54g3RSjTtdhQUEycHK f11RPVSMcsJKGXutBn8i1OaTka4bceDmlR9UFTcHxhxg5AibhpeEKRzueEPVqQD8az /Qw5K1E6zKgSGcUpMteO/j0ZmdW+E9Oj/OVX+8KU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kaixin Wang , Miquel Raynal , Frank Li , Alexandre Belloni Subject: [PATCH 6.10 374/482] i3c: master: svc: Fix use after free vulnerability in svc_i3c_master Driver Due to Race Condition Date: Tue, 8 Oct 2024 14:07:17 +0200 Message-ID: <20241008115703.139781424@linuxfoundation.org> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241008115648.280954295@linuxfoundation.org> References: <20241008115648.280954295@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kaixin Wang commit 61850725779709369c7e907ae8c7c75dc7cec4f3 upstream. In the svc_i3c_master_probe function, &master->hj_work is bound with svc_i3c_master_hj_work, &master->ibi_work is bound with svc_i3c_master_ibi_work. And svc_i3c_master_ibi_work can start the hj_work, svc_i3c_master_irq_handler can start the ibi_work. If we remove the module which will call svc_i3c_master_remove to make cleanup, it will free master->base through i3c_master_unregister while the work mentioned above will be used. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | svc_i3c_master_hj_work svc_i3c_master_remove | i3c_master_unregister(&master->base)| device_unregister(&master->dev) | device_release | //free master->base | | i3c_master_do_daa(&master->base) | //use master->base Fix it by ensuring that the work is canceled before proceeding with the cleanup in svc_i3c_master_remove. Fixes: 0f74f8b6675c ("i3c: Make i3c_master_unregister() return void") Cc: stable@vger.kernel.org Signed-off-by: Kaixin Wang Reviewed-by: Miquel Raynal Reviewed-by: Frank Li Link: https://lore.kernel.org/stable/20240914154030.180-1-kxwang23%40m.fudan.edu.cn Link: https://lore.kernel.org/r/20240914163932.253-1-kxwang23@m.fudan.edu.cn Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1750,6 +1750,7 @@ static void svc_i3c_master_remove(struct { struct svc_i3c_master *master = platform_get_drvdata(pdev); + cancel_work_sync(&master->hj_work); i3c_master_unregister(&master->base); pm_runtime_dont_use_autosuspend(&pdev->dev);