From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8DED199FAF for ; Wed, 9 Oct 2024 14:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728485283; cv=none; b=pjC6Tn/XCgwxVhOUaOmcZuPRsWNLerbeCI7fZRLGzha0t4nSyjs3EvlVeTousX8m4hHntSayaUMOhbXOLj4mf60RDKKMsA9nLWJdND0i+VtVAYxi+4B6gRHbygp3EL71i+ChotjcXEnZjXv0kMiXCzNGO0uhd2OgrrjRodyMf08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728485283; c=relaxed/simple; bh=Uk0KPCtVm1MKB9yeaaWwBQIEavfH89OFn7myYjG6PVc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dO8/Pz3AL4ii47gexuZ+v79cz+fJQcNVK+FWvKYKeVc3Y2o4szofGt8WLfFG8WCsyWsYjIsOLbA1Iu5VN9sMjo9o2F3D5blxC10EA05HsiYVnk4EMkOgJqEKLodFgS5f0gieOfwrHdf5vl+g1UbNa5vHfTc16VT2WhgQH9asMX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GN3QVd8v; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GN3QVd8v" Received: by mail.gandi.net (Postfix) with ESMTPSA id E81131C000A; Wed, 9 Oct 2024 14:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728485279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uk0KPCtVm1MKB9yeaaWwBQIEavfH89OFn7myYjG6PVc=; b=GN3QVd8vooavbeQJM+8xQxNXCaS6ufJA89s1aJ5pznYI/d9rODUASXTo6A1fhLCdmG0UOq TBVDSuD59Z9K2Yk5m6dYdUcncz3SrPkpsUn+2uu/1EmuMAxNZeaLrjUoy7Kkl2Hfyn8a0E uVexEHTaCNSVwHhN1y3rwQdmIp9dA59jofbwf8DMVE6VotDQPmUnEwM8XMvJo0OATbOnuq 72qKnUuVzu5sjJjPEYpBDygh8W/Sr7tMX3UIXpTbAhQtZ3erd+fDDY6QAPxbQOFvwIi/go S0oEx3l/42HkVZJfScvSL/+fWjkfXMTgkXZUbcB7GWrNn3P6Y+BM6cGPlfxauw== Date: Wed, 9 Oct 2024 16:47:57 +0200 From: Miquel Raynal To: Frieder Schrempf Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Steam Lin , Thomas Petazzoni , Md Sadre Alam , Sridharan S N , stable@vger.kernel.org Subject: Re: [PATCH 2/4] mtd: spi-nand: winbond: Fix 512GW, 01GW, 01JW and 02JW ECC information Message-ID: <20241009164757.049d702c@xps-13> In-Reply-To: <3345c66e-6f18-4bc7-8e52-4af7de6ff401@kontron.de> References: <20241009125002.191109-1-miquel.raynal@bootlin.com> <20241009125002.191109-3-miquel.raynal@bootlin.com> <3345c66e-6f18-4bc7-8e52-4af7de6ff401@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Frieder, frieder.schrempf@kontron.de wrote on Wed, 9 Oct 2024 15:33:11 +0200: > On 09.10.24 2:50 PM, Miquel Raynal wrote: > > These four chips: > > * W25N512GW > > * W25N01GW > > * W25N01JW > > * W25N02JW > > all require a single bit of ECC strength and thus feature an on-die > > Hamming-like ECC engine. There is no point in filling a ->get_status() > > callback for them because the main ECC status bytes are located in > > standard places, and retrieving the number of bitflips in case of > > corrected chunk is both useless and unsupported (if there are bitflips, > > then there is 1 at most, so no need to query the chip for that). > >=20 > > Without this change, a kernel warning triggers every time a bit flips. > >=20 > > Fixes: 6a804fb72de5 ("mtd: spinand: winbond: add support for serial NAN= D flash") > > Cc: stable@vger.kernel.org > > Signed-off-by: Miquel Raynal =20 >=20 > I had a quick look at the datasheets and this seems correct to me. Thanks a lot for the rapid review! > Reviewed-by: Frieder Schrempf Thanks, Miqu=C3=A8l