public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: x86@kernel.org, llvm@lists.linux.dev,
	linux-hardening@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	stable@vger.kernel.org, Fangrui Song <i@maskray.me>,
	Brian Gerst <brgerst@gmail.com>, Uros Bizjak <ubizjak@gmail.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2] x86/stackprotector: Work around strict Clang TLS symbol requirements
Date: Mon, 14 Oct 2024 13:59:49 -0700	[thread overview]
Message-ID: <202410141357.3B2A71A340@keescook> (raw)
In-Reply-To: <20241009124352.3105119-2-ardb+git@google.com>

On Wed, Oct 09, 2024 at 02:43:53PM +0200, Ard Biesheuvel wrote:
> However, if a non-TLS definition of the symbol in question is visible in
> the same compilation unit (which amounts to the whole of vmlinux if LTO
> is enabled), it will drop the per-CPU prefix and emit a load from a
> bogus address.

I take this to mean that x86 32-bit kernels built with the stack
protector and using Clang LTO will crash very quickly?

-- 
Kees Cook

  reply	other threads:[~2024-10-14 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 12:43 [PATCH v2] x86/stackprotector: Work around strict Clang TLS symbol requirements Ard Biesheuvel
2024-10-14 20:59 ` Kees Cook [this message]
2024-10-15 10:56   ` Ard Biesheuvel
2024-10-16  2:10     ` Nathan Chancellor
2024-10-16  6:48       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410141357.3B2A71A340@keescook \
    --to=kees@kernel.org \
    --cc=ardb+git@google.com \
    --cc=ardb@kernel.org \
    --cc=brgerst@gmail.com \
    --cc=i@maskray.me \
    --cc=linux-hardening@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=luto@kernel.org \
    --cc=nathan@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=ubizjak@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox