From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A56017C77; Mon, 14 Oct 2024 14:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728916607; cv=none; b=Vh7iRRI9ghajHQKFPkia+zPbnLF+llor2Vii9c1tj/U2dT+79aCK3Ktp9HY01v995fF1KujLcr8Z2H3hv8XLpV70WXLqyIXSMPUEKFOhwx9hSPvx25YdBEVVIlHu7huC00Ct6p1b5KBWXYvw5BFJG6miok2NeUr00ZVtIFqWw4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728916607; c=relaxed/simple; bh=WzfoRuXdXQ79V4kXQjkv39XKSRWa8KHjZws6cbX26XU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ndQxKkoP1ysLhJw4qlsk9uZ2XdsQ5zCZyJMuBS1n8owf6VOOCIQrFppSLoUA1dS98Z6vDsn+53PX/94Nj8f89l+AQhaYu0O32Eml7ikz8ONDkyy0SCIHCIg8mC4mkz6bcjGsq5mCeHOEKtGf2qgmXdr9jCv6zOth2FxoPtWBwx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lZGhM2/8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lZGhM2/8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89CE8C4CEC3; Mon, 14 Oct 2024 14:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728916606; bh=WzfoRuXdXQ79V4kXQjkv39XKSRWa8KHjZws6cbX26XU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lZGhM2/8Msbp2Ii5laaJFWGPAHQUt7QtxtHh4Z0PoO86O6xOaCVpQ/yIytiJA2RgU xlPyj0B4+rH6H78exHarNbDgearDM6dCFL0zhUgkkhWYis1WjgGVq36OQN7a/tOJik i8msnbUrM2/Tosr+j9r8kNf5I0evDnOsl+FjK9pU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rob Clark , Daniel Vetter , Abhinav Kumar , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 6.6 016/213] drm/crtc: fix uninitialized variable use even harder Date: Mon, 14 Oct 2024 16:18:42 +0200 Message-ID: <20241014141043.617615209@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241014141042.954319779@linuxfoundation.org> References: <20241014141042.954319779@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rob Clark [ Upstream commit b6802b61a9d0e99dcfa6fff7c50db7c48a9623d3 ] DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), which means we can't rely too much on variable initializers. Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov # sc7180, sdm845 Link: https://patchwork.freedesktop.org/patch/msgid/20240212215534.190682-1-robdclark@gmail.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index cb90e70d85e86..65f9f66933bba 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -904,6 +904,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, connector_set = NULL; fb = NULL; mode = NULL; + num_connectors = 0; DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); -- 2.43.0