From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9073B1C07F0; Tue, 15 Oct 2024 12:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728996936; cv=none; b=sR6QgkdGXARz1gzt81WdEZeD7ZaJ2V38gn2dYko5Km/BJQBvsPYyLGC9WG9rbkE7wyC0ll7D+nEzZf3hHKY5OcIeEWCar13xFkU0deee2JaBz9oQfFZFqiu6tRavowYhXfoNyxAIM335oZWU9kE+HACaFS5aNTTB1eH6UgbEI8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728996936; c=relaxed/simple; bh=Mc5PertM7Iwv7WiuwQ18lE50aHgcY177lbH5pZMr1nQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KQdnuq/HHJZrEBdUKb5ShPVtG0KgQrT2LYIBpYMdr+iNfMYOTR6+F4h45824eRCKf7aEXvIbLyL3voLxKO57Jl7/t9JAUffwVAdkiOYaydd+5RrvMo7F/2jzGqAIfVe/jwdNWTVSaYUOuYxdi8mo+TWdxpc7qJtjFY4EsJVI1tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MlJcUBZ3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MlJcUBZ3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7672C4CEC6; Tue, 15 Oct 2024 12:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728996936; bh=Mc5PertM7Iwv7WiuwQ18lE50aHgcY177lbH5pZMr1nQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MlJcUBZ3PYNiokuIj8exN+9lfHra8uqu42WlkN5RtUJNdp5Wcot3nOcuP+MVpX+Zn okWkdto1p3e7kg/VfKq3YGYXRbt73HJ7o6WLYhBXbO9Ug5/lw/s3dxGleVsUEmpPFm PH3zSDab6/yeoo27Gxe8B6dQogHxdDGWyx8+sABo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ferry Meng , Joseph Qi , lei lu , Changwei Ge , Gang He , Joel Becker , Jun Piao , Junxiao Bi , Mark Fasheh , Andrew Morton , Sasha Levin Subject: [PATCH 5.10 043/518] ocfs2: strict bound check before memcmp in ocfs2_xattr_find_entry() Date: Tue, 15 Oct 2024 14:39:07 +0200 Message-ID: <20241015123918.673900351@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ferry Meng [ Upstream commit af77c4fc1871847b528d58b7fdafb4aa1f6a9262 ] xattr in ocfs2 maybe 'non-indexed', which saved with additional space requested. It's better to check if the memory is out of bound before memcmp, although this possibility mainly comes from crafted poisonous images. Link: https://lkml.kernel.org/r/20240520024024.1976129-2-joseph.qi@linux.alibaba.com Signed-off-by: Ferry Meng Signed-off-by: Joseph Qi Reported-by: lei lu Reviewed-by: Joseph Qi Cc: Changwei Ge Cc: Gang He Cc: Joel Becker Cc: Jun Piao Cc: Junxiao Bi Cc: Mark Fasheh Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/ocfs2/xattr.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 31b389d0a09a0..977a739d5448f 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -1074,7 +1074,7 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, { struct ocfs2_xattr_entry *entry; size_t name_len; - int i, cmp = 1; + int i, name_offset, cmp = 1; if (name == NULL) return -EINVAL; @@ -1089,10 +1089,15 @@ static int ocfs2_xattr_find_entry(struct inode *inode, int name_index, cmp = name_index - ocfs2_xattr_get_type(entry); if (!cmp) cmp = name_len - entry->xe_name_len; - if (!cmp) - cmp = memcmp(name, (xs->base + - le16_to_cpu(entry->xe_name_offset)), - name_len); + if (!cmp) { + name_offset = le16_to_cpu(entry->xe_name_offset); + if ((xs->base + name_offset + name_len) > xs->end) { + ocfs2_error(inode->i_sb, + "corrupted xattr entries"); + return -EFSCORRUPTED; + } + cmp = memcmp(name, (xs->base + name_offset), name_len); + } if (cmp == 0) break; entry += 1; -- 2.43.0