From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FBC51C07C4; Tue, 15 Oct 2024 13:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997228; cv=none; b=jjcWy1rXVaY5vCjrwt4FsYo0kFHTqjVOd9MHJwbuYZzi/Z+gha0fxr9gRafLF7muto3DYtB++FwG/R78FySuLkSP56SlDuGqaQxB8R83/RQlK8nX268EVdg/2oN83i3YZ2XC6ZwatFZwaw29ke/FAiDQafSutvzrXO/zXeXnx+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997228; c=relaxed/simple; bh=6U8ngyw/hew8wGJN5lRNKEu26UfZsSCY3n95w6rl6/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X3SARsAh11RpwDEyspLKs2QfqKXvi1SSj9qjoJiHawgQjTglR9pj5Nag0s9WUn1FeKr7wfFZza+Rl4OlBSBXFonvn2SEo8n7CTIJKXWtF5eHEr7Zmc1GSLc/kFjywEVfux0ka3zQKWz6DHtjQE3qeyKlJq73a7voJqkZs7OX65M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bHKJKM8s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bHKJKM8s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69B36C4CEC6; Tue, 15 Oct 2024 13:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997227; bh=6U8ngyw/hew8wGJN5lRNKEu26UfZsSCY3n95w6rl6/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bHKJKM8sHtyldR/N9KZ611GR+rzA3IOQHf3WT0BUgK8I2JZYycUmYMnnxc6TnBmPq m1CbXHGd2CBAovNJleB/ldKKxgupN7RKctYP74rfVf2A2eWN6iersyZ95cd4MkPn70 WsGEtwBv6ecAiaxwXLxIyAeM8XhFXt7Z0+fFrdx4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Mishin , Dmitry Baryshkov , Rob Clark , Sasha Levin Subject: [PATCH 5.10 123/518] drm/msm: Fix incorrect file name output in adreno_request_fw() Date: Tue, 15 Oct 2024 14:40:27 +0200 Message-ID: <20241015123921.743292314@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Mishin [ Upstream commit e19366911340c2313a1abbb09c54eaf9bdea4f58 ] In adreno_request_fw() when debugging information is printed to the log after firmware load, an incorrect filename is printed. 'newname' is used instead of 'fwname', so prefix "qcom/" is being added to filename. Looks like "copy-paste" mistake. Fix this mistake by replacing 'newname' with 'fwname'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2c41ef1b6f7d ("drm/msm/adreno: deal with linux-firmware fw paths") Signed-off-by: Aleksandr Mishin Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.org/patch/602382/ Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index a5f95801adfe9..773bd463ad47e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -308,7 +308,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname) ret = request_firmware_direct(&fw, fwname, drm->dev); if (!ret) { DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n", - newname); + fwname); adreno_gpu->fwloc = FW_LOCATION_LEGACY; goto out; } else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) { -- 2.43.0