From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E941C07DB; Tue, 15 Oct 2024 13:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997365; cv=none; b=RKIw3gOSf+g11kgNgEeui+ABKhoGzTDHam33Ofabo6qKD1t0t1QudN8P7VS9a6SNzKtxJjxR2W54fJpcDq9FSnB0R4i+IGsb9xqHJGt4dyf62kH3nwyF6YtBfJ/a1ww3m9oz/YXXbjSs0IEaopP9DG94kiSfjI+ue5C8vxae6G8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997365; c=relaxed/simple; bh=NpUtAe26iRbmMOul+QNeQF7xgIgfkjYHQ2FIOKFX8h4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gz2KSiR71wQ4U/VbJEUj0EKM/uO28/H/pkTmZV1FeqW+r8r604UlOa26knRdP/s8VjRxdNxcVxLts/nAmKQmHa305YnZBGg9RmcmdUSohXFjRmZmAGXuZXPp9iPN5WEv0Lpz/6wmQBOaqGqdhzUiM9vtFEX0ti9HEWlq6f9KTCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eTRB16Wt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eTRB16Wt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52788C4CEC6; Tue, 15 Oct 2024 13:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997364; bh=NpUtAe26iRbmMOul+QNeQF7xgIgfkjYHQ2FIOKFX8h4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eTRB16WtZiWCwIApAixNiuLmJXEhVjse2ZEQH9iJyfmeR26yGgVY+MYJS0P2nfemu SEKdhtPQqTq6DQSnkwB4tQ5u0m8npMoaJl59TdGVx0CjLYeWMLs1fYCg9wNGE4N7A8 w1CkPTYowEeIVakdM5yYiSYnikIgshQaqm0FVlMQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Juergen Gross , Stefano Stabellini , Sasha Levin Subject: [PATCH 5.10 134/518] xen/swiotlb: add alignment check for dma buffers Date: Tue, 15 Oct 2024 14:40:38 +0200 Message-ID: <20241015123922.166861309@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Juergen Gross [ Upstream commit 9f40ec84a7976d95c34e7cc070939deb103652b0 ] When checking a memory buffer to be consecutive in machine memory, the alignment needs to be checked, too. Failing to do so might result in DMA memory not being aligned according to its requested size, leading to error messages like: 4xxx 0000:2b:00.0: enabling device (0140 -> 0142) 4xxx 0000:2b:00.0: Ring address not aligned 4xxx 0000:2b:00.0: Failed to initialise service qat_crypto 4xxx 0000:2b:00.0: Resetting device qat_dev0 4xxx: probe of 0000:2b:00.0 failed with error -14 Fixes: 9435cce87950 ("xen/swiotlb: Add support for 64KB page granularity") Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/swiotlb-xen.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index ad3ee4857e154..000d02ea4f7d8 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -91,9 +91,15 @@ static inline int range_straddles_page_boundary(phys_addr_t p, size_t size) { unsigned long next_bfn, xen_pfn = XEN_PFN_DOWN(p); unsigned int i, nr_pages = XEN_PFN_UP(xen_offset_in_page(p) + size); + phys_addr_t algn = 1ULL << (get_order(size) + PAGE_SHIFT); next_bfn = pfn_to_bfn(xen_pfn); + /* If buffer is physically aligned, ensure DMA alignment. */ + if (IS_ALIGNED(p, algn) && + !IS_ALIGNED((phys_addr_t)next_bfn << XEN_PAGE_SHIFT, algn)) + return 1; + for (i = 1; i < nr_pages; i++) if (pfn_to_bfn(++xen_pfn) != ++next_bfn) return 1; -- 2.43.0