From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675BC1C07E0; Tue, 15 Oct 2024 13:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997471; cv=none; b=Cqer0HUAsnVbt8GohnswoOP8SLKbV7RDR6qEIHYMUz56JmOBeBNui4rdxUhnrFSh+YiFjKiVtysAkHK4FdKjQT+J7COZtIiLwB9MICTzXoVSB+n66kEBoKVKS9OkPdbGwReB6lqm/+4yrDBn2Pg4hy1fj/OQtxeYg1MLNZMuVCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997471; c=relaxed/simple; bh=8mIJ09GftxTdx4+AFb3CDiJTVvg5DBSPdUxi39wIMdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H1xvKgzhDGyXQd65izOfiCxNhMEHRCnds40tI8woawVO9k4rbrgznHE1uzPot7JdBZXSf9LwZkw5Mc0kPh25bIUGr1yqWcgFEM/z2MkBcLyE63y3FFthVCtx8ua2iPC5peNuAWBO+2vD0fePhx9+lU6GVDcldDQqGxWnmtyPXAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0T8kRYSc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0T8kRYSc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD19AC4CEC6; Tue, 15 Oct 2024 13:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997471; bh=8mIJ09GftxTdx4+AFb3CDiJTVvg5DBSPdUxi39wIMdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0T8kRYSccK5/NYc9xHPDFBc5QSXExCNQcWfsF5iJmIquZXFmMLWNmeH+TCzKr31ZQ 0jGiEv4Q/XmjgcgV4NvvuBInnDWkVLbnohX5BQ9K4ef/KYNPEuHxJ4KUmvXwL0BH4n cMBlE6jRW2CZMEx+M7l/L/NK0aWk1yCWyX0C9rEg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexander Stein , Mark Brown , Sasha Levin Subject: [PATCH 5.10 192/518] spi: lpspi: release requested DMA channels Date: Tue, 15 Oct 2024 14:41:36 +0200 Message-ID: <20241015123924.392881704@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexander Stein [ Upstream commit f02bff30114f385d53ae3e45141db602923bca5d ] The requested DMA channels are never released. Do this in .remove as well as in .probe. spi_register_controller() can return -EPROBE_DEFER if cs-gpios are not probed yet. Signed-off-by: Alexander Stein Link: https://lore.kernel.org/r/20211109103134.184216-1-alexander.stein@ew.tq-group.com Signed-off-by: Mark Brown Stable-dep-of: 3b577de206d5 ("spi: spi-fsl-lpspi: Undo runtime PM changes at driver exit time") Signed-off-by: Sasha Levin --- drivers/spi/spi-fsl-lpspi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index bc3e434ba2986..314629b172281 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -920,7 +920,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) ret = devm_spi_register_controller(&pdev->dev, controller); if (ret < 0) { dev_err_probe(&pdev->dev, ret, "spi_register_controller error: %i\n", ret); - goto out_pm_get; + goto free_dma; } pm_runtime_mark_last_busy(fsl_lpspi->dev); @@ -928,6 +928,8 @@ static int fsl_lpspi_probe(struct platform_device *pdev) return 0; +free_dma: + fsl_lpspi_dma_exit(controller); out_pm_get: pm_runtime_dont_use_autosuspend(fsl_lpspi->dev); pm_runtime_put_sync(fsl_lpspi->dev); @@ -944,6 +946,8 @@ static int fsl_lpspi_remove(struct platform_device *pdev) struct fsl_lpspi_data *fsl_lpspi = spi_controller_get_devdata(controller); + fsl_lpspi_dma_exit(controller); + pm_runtime_disable(fsl_lpspi->dev); return 0; } -- 2.43.0