From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0AE1C07ED; Tue, 15 Oct 2024 13:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997833; cv=none; b=PqvTQlGuymTxgp3ikqxpTpbdbAGGuvX8d4CFlgvGAqibcfDJ9mCO2ltRZCde9HIRohHUkfjxAQhWlQtRdF56HBuIEPOCiJRZWhy85K3m3yGP+ch3aiI7oIht33jBPuz2ohTJwpCQm9UbvPCecQpQa2SALcp8TabYgqx0k7MVp5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728997833; c=relaxed/simple; bh=Yehf8Eah6HWoaHKteWt7+bnapgff01kpOxjAln99yhU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nolUxfYo+9Cu5m/ioDWpXpZapdS7UsILrKkVHdjE9v4E61SkA5X/NoMYodczUCjTJcxm04BIXG6T5BwC67dGhZgu62BG0TWfCrWEdY9YvlGstPUlp3xMn7x150kP5fYyNM/wmxDHHK8P7HumWQoD2YHtxfqulKKp5gvhUzIOdzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FsaGN3tG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FsaGN3tG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0200C4CEC6; Tue, 15 Oct 2024 13:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728997833; bh=Yehf8Eah6HWoaHKteWt7+bnapgff01kpOxjAln99yhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FsaGN3tGFSYdUHKNCSxSau0V+SzRa4oJ3iPPgB/eIG5jUmp3Y4mpT8zLMc0AFp8CB iN5Er1jS5+5cPXdrf5fOqQAqhOSMdRfHUasIG0BE+pGn3WM6hxQSOfya/z+92pyWuW jodXXxiLEuFkq2pNoK+zJljTMDHuLyYupRi/8j4Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 299/518] net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info() Date: Tue, 15 Oct 2024 14:43:23 +0200 Message-ID: <20241015123928.528825882@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski [ Upstream commit 5680cf8d34e1552df987e2f4bb1bff0b2a8c8b11 ] Driver is leaking OF node reference from of_parse_phandle_with_fixed_args() in hns_mac_get_info(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Horman Link: https://patch.msgid.link/20240827144421.52852-3-krzysztof.kozlowski@linaro.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 1f44a6463f45b..5929ac50e3517 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -933,6 +933,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) mac_cb->cpld_ctrl = NULL; } else { syscon = syscon_node_to_regmap(cpld_args.np); + of_node_put(cpld_args.np); if (IS_ERR_OR_NULL(syscon)) { dev_dbg(mac_cb->dev, "no cpld-syscon found!\n"); mac_cb->cpld_ctrl = NULL; -- 2.43.0