From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B68601D90A4; Tue, 15 Oct 2024 13:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998204; cv=none; b=fn3Cihd2QuHkC8zxCx7FFTCCI9phDZffJwMhJiiBQnEoN+oE1tv354rmfYHvxZqyGwmPJwThPMXBcWhAvVqutA5s9gfvlYBFVwuX/ssxUpz7jQIk7+GpzcW16LFYj8CMv1wsB+lrlJDhUEGeRIjnnGn8dEP+0cDEbI0LK22h6kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998204; c=relaxed/simple; bh=4BeQdf06kRIwg4jz5f6hVW5RPW00ATEaffLG6aH7Htg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a5ZTcpYjgFfuzmrksy0xglxZdc11DOycsm4wUWzJUTzkOySN4zU7aHMbA0yoTU5OwsbxCD6rq76cxxDZc00UjAzpoQ75l3ZgL7gH+1dS7QbjMUQNpqB6X24XuqjURG6QoODBED0VVzAOFWuWUEG0FHw92vYf6efRDC9/SLEmGAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zY2W44Wk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zY2W44Wk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4E37C4CEC6; Tue, 15 Oct 2024 13:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998203; bh=4BeQdf06kRIwg4jz5f6hVW5RPW00ATEaffLG6aH7Htg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zY2W44WkyVlJPsLcLO7JSd0P+tp/I30qAh5j4ei6rBRuD1+Ji6kTfsz9DEbz+1S2V Zap9RL7+ZWUxkXIaM6qry43PM/AvcKgFe0nkhh0F0KyO0sZcSr62/5Gc9tSrwZ5m3k qS7/71SgAKPGVsQCT9mzl+Tq80a4sVNvKYB5hPWk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Baokun Li , Jan Kara , Theodore Tso Subject: [PATCH 5.10 377/518] ext4: update orig_path in ext4_find_extent() Date: Tue, 15 Oct 2024 14:44:41 +0200 Message-ID: <20241015123931.522755582@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Baokun Li commit 5b4b2dcace35f618fe361a87bae6f0d13af31bc1 upstream. In ext4_find_extent(), if the path is not big enough, we free it and set *orig_path to NULL. But after reallocating and successfully initializing the path, we don't update *orig_path, in which case the caller gets a valid path but a NULL ppath, and this may cause a NULL pointer dereference or a path memory leak. For example: ext4_split_extent path = *ppath = 2000 ext4_find_extent if (depth > path[0].p_maxdepth) kfree(path = 2000); *orig_path = path = NULL; path = kcalloc() = 3000 ext4_split_extent_at(*ppath = NULL) path = *ppath; ex = path[depth].p_ext; // NULL pointer dereference! ================================================================== BUG: kernel NULL pointer dereference, address: 0000000000000010 CPU: 6 UID: 0 PID: 576 Comm: fsstress Not tainted 6.11.0-rc2-dirty #847 RIP: 0010:ext4_split_extent_at+0x6d/0x560 Call Trace: ext4_split_extent.isra.0+0xcb/0x1b0 ext4_ext_convert_to_initialized+0x168/0x6c0 ext4_ext_handle_unwritten_extents+0x325/0x4d0 ext4_ext_map_blocks+0x520/0xdb0 ext4_map_blocks+0x2b0/0x690 ext4_iomap_begin+0x20e/0x2c0 [...] ================================================================== Therefore, *orig_path is updated when the extent lookup succeeds, so that the caller can safely use path or *ppath. Fixes: 10809df84a4d ("ext4: teach ext4_ext_find_extent() to realloc path if necessary") Cc: stable@kernel.org Signed-off-by: Baokun Li Reviewed-by: Jan Kara Link: https://patch.msgid.link/20240822023545.1994557-6-libaokun@huaweicloud.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/extents.c | 3 ++- fs/ext4/move_extent.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -949,6 +949,8 @@ ext4_find_extent(struct inode *inode, ex ext4_ext_show_path(inode, path); + if (orig_path) + *orig_path = path; return path; err: @@ -3245,7 +3247,6 @@ static int ext4_split_extent_at(handle_t } depth = ext_depth(inode); ex = path[depth].p_ext; - *ppath = path; if (EXT4_EXT_MAY_ZEROOUT & split_flag) { if (split_flag & (EXT4_EXT_DATA_VALID1|EXT4_EXT_DATA_VALID2)) { --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -36,7 +36,6 @@ get_ext_path(struct inode *inode, ext4_l *ppath = NULL; return -ENODATA; } - *ppath = path; return 0; }