From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 669441DD0DE; Tue, 15 Oct 2024 13:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998345; cv=none; b=sgOJdMuZ9f4Eg9Q6AAaEgqZ7bYzsOxdfiagezweE3pAlcgGkubz+FCdiExovL1kjr/gx9yCVGF3mGYI+3al4lb9Zy7hEWEkIkZB/YFo0W8eyRxBKg5vHHkBZqQS9qXxM8xbb5BCBMftR1tTgt1kOagMaKQcihcM7IYW5Gl2Jvn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998345; c=relaxed/simple; bh=cnVX2OnbEX3q1DkSjsoxR8Ox3rsNj05tM5SqIHsfLxc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UG2MZQiONMSeW4ISytpsKc82YGGS9alZdNyvivVM3eIEzwsw4uFYYF4mL2E2IOjF9ufaU2c0173xOEubsFhO0VSiJJnwBFrIG4TxWfDRfZzJqRJ3ThwY/GsYmQyZJatQr1lQFXA420naM89uRXgFXwVuznM1cQIRrlOUS3o51HA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ErmVjJMr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ErmVjJMr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC1EDC4CEC6; Tue, 15 Oct 2024 13:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998345; bh=cnVX2OnbEX3q1DkSjsoxR8Ox3rsNj05tM5SqIHsfLxc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ErmVjJMrzkjCYiOEmP+DnmYrHAv8+q3BXtbNQYVyacygbUVys2nzCcp6g41iaJbtS z5B8cBSpqsB9Zd/INk9OgXbtm3tNtpWqKaE64NiyaYASgiDZoiA7cjpHX1K96E1VR/ aQN4hqPxLfdF6Q70lXpmIbiUs5cYUXFDeRG5sxP8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gerald Schaefer , Heiko Carstens , Sasha Levin Subject: [PATCH 5.10 451/518] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Date: Tue, 15 Oct 2024 14:45:55 +0200 Message-ID: <20241015123934.415109616@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gerald Schaefer [ Upstream commit 131b8db78558120f58c5dc745ea9655f6b854162 ] Adding/removing large amount of pages at once to/from the CMM balloon can result in rcu_sched stalls or workqueue lockups, because of busy looping w/o cond_resched(). Prevent this by adding a cond_resched(). cmm_free_pages() holds a spin_lock while looping, so it cannot be added directly to the existing loop. Instead, introduce a wrapper function that operates on maximum 256 pages at once, and add it there. Signed-off-by: Gerald Schaefer Reviewed-by: Heiko Carstens Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- arch/s390/mm/cmm.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 1141c8d5c0d03..9b4304fa37bfc 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -95,11 +95,12 @@ static long cmm_alloc_pages(long nr, long *counter, (*counter)++; spin_unlock(&cmm_lock); nr--; + cond_resched(); } return nr; } -static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +static long __cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) { struct cmm_page_array *pa; unsigned long addr; @@ -123,6 +124,21 @@ static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) return nr; } +static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +{ + long inc = 0; + + while (nr) { + inc = min(256L, nr); + nr -= inc; + inc = __cmm_free_pages(inc, counter, list); + if (inc) + break; + cond_resched(); + } + return nr + inc; +} + static int cmm_oom_notify(struct notifier_block *self, unsigned long dummy, void *parm) { -- 2.43.0