From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96351E6321; Tue, 15 Oct 2024 13:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998518; cv=none; b=oIK+HIZGsffUSDFmXTpQFlVuQt2MFc4OMmI8ZxutlyJmiT2fgJ3YgriCgB9g8sj+8DDuSk6bjpycY+TZhoSlhj645F7mvI6S5TU3u/HVw1MgGEKBI2BRGRstNF3QdThVJG7WMrr3qdWP+yhDEhKFRjeNFVOJVgjgDVlC8Zb7wFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998518; c=relaxed/simple; bh=IueWrLqPq1micJ43bEiA6ctdVLNorTrLbSYZ8mfDqeU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZE1+okkAqa5/B/hLXIRiFb8NOVOchc5GcYb3ecn/Pi92XbqR0g5VIPnpOsnr+cGS0X6mbMeaLtuGsEABkkS1GQQ/Z5PrtmaomovGjrWAvu9sHqjKUlbUrOR6krfrHy6nrPGSE6En0QsySeGX2lLKtyeh1pFssKlWcCSHE2kFYDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qVh10P83; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qVh10P83" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49387C4CEC6; Tue, 15 Oct 2024 13:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998518; bh=IueWrLqPq1micJ43bEiA6ctdVLNorTrLbSYZ8mfDqeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qVh10P83jHtFC9Z3+5eSxowxXnkqyeL1A77uyHzUNLzFCtu1DFPVMVTEQGhvftVvt TfdivoV+DgtJS+d+4yeCR7esx52mBMiBS0rmeJGpU6UhN7ik8jonSMX0XyRTVBx+IJ 6WG+MHbTnWWrp6JRAisl8LYhbdmv5x5COCcTjESY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Przemek Kitszel , Dave Ertman , Jacob Keller , Tony Nguyen , Sasha Levin , Pucha Himasekhar Reddy Subject: [PATCH 5.10 473/518] ice: fix VLAN replay after reset Date: Tue, 15 Oct 2024 14:46:17 +0200 Message-ID: <20241015123935.261704598@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dave Ertman [ Upstream commit 0eae2c136cb624e4050092feb59f18159b4f2512 ] There is a bug currently when there are more than one VLAN defined and any reset that affects the PF is initiated, after the reset rebuild no traffic will pass on any VLAN but the last one created. This is caused by the iteration though the VLANs during replay each clearing the vsi_map bitmap of the VSI that is being replayed. The problem is that during rhe replay, the pointer to the vsi_map bitmap is used by each successive vlan to determine if it should be replayed on this VSI. The logic was that the replay of the VLAN would replace the bit in the map before the next VLAN would iterate through. But, since the replay copies the old bitmap pointer to filt_replay_rules and creates a new one for the recreated VLANS, it does not do this, and leaves the old bitmap broken to be used to replay the remaining VLANs. Since the old bitmap will be cleaned up in post replay cleanup, there is no need to alter it and break following VLAN replay, so don't clear the bit. Fixes: 334cb0626de1 ("ice: Implement VSI replay framework") Reviewed-by: Przemek Kitszel Signed-off-by: Dave Ertman Reviewed-by: Jacob Keller Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_switch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c index 1645fb527fdb7..68d756e86ca15 100644 --- a/drivers/net/ethernet/intel/ice/ice_switch.c +++ b/drivers/net/ethernet/intel/ice/ice_switch.c @@ -2789,8 +2789,6 @@ ice_replay_vsi_fltr(struct ice_hw *hw, u16 vsi_handle, u8 recp_id, if (!itr->vsi_list_info || !test_bit(vsi_handle, itr->vsi_list_info->vsi_map)) continue; - /* Clearing it so that the logic can add it back */ - clear_bit(vsi_handle, itr->vsi_list_info->vsi_map); f_entry.fltr_info.vsi_handle = vsi_handle; f_entry.fltr_info.fltr_act = ICE_FWD_TO_VSI; /* update the src in case it is VSI num */ -- 2.43.0