From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028C6229106; Tue, 15 Oct 2024 13:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998532; cv=none; b=YAmCpIn5MERuC0wDOQgJIXXw6Ob93GcNolJ7HnvDu+cns7jGKyWI/f9TO2L7/W6JAwkOwDBgnGxQcXbOwLZNmzlWNxUSz7azcJqBlFIk8GiX7Gk6iJa545S40NiedJ/OPhFxapbQUu3PBzlUbVxkUdDYWu/jMZkXvUnf4omvtOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728998532; c=relaxed/simple; bh=6I1XYGhNUS2pmT8aIzUW0nLmJCTG6I3KJ8sZIl7f3+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tRHIBW7cs0QLXLRh4D6cVwJ8VucO32kqXM0ltvDTqkW2EHpMcMpSNnPltaGnk8AsCh/Jv7JK5DUfTCxKHvB7TzGCvPdopPE2nxUf5+KzW2Js8GMIS8kxTPXLJozCCNuAI1uO3ldmI2aQZj5wQ10C45QSSh0GsVdVe5iK9JFFsAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=w2a8OSy7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="w2a8OSy7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D9A9C4CEC6; Tue, 15 Oct 2024 13:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728998531; bh=6I1XYGhNUS2pmT8aIzUW0nLmJCTG6I3KJ8sZIl7f3+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w2a8OSy7RANPJRiP50uboyN2dhChY62POlT1t5/2DOu49aMcF1b4VhOFIhQBX8V3B EyHGKDykEsxyDswkdOZ3F1rVaBvKHjeQifwcodHyDIDiM/RcaNqoNc4ooMJ15d5Scv o3pCf8+upRsIfq2IiqO8etipp5jCW+6i3AlprM28= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oliver Neukum , stable Subject: [PATCH 5.10 503/518] Revert "usb: yurex: Replace snprintf() with the safer scnprintf() variant" Date: Tue, 15 Oct 2024 14:46:47 +0200 Message-ID: <20241015123936.406339034@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241015123916.821186887@linuxfoundation.org> References: <20241015123916.821186887@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum commit 71c717cd8a2e180126932cc6851ff21c1d04d69a upstream. This reverts commit 86b20af11e84c26ae3fde4dcc4f490948e3f8035. This patch leads to passing 0 to simple_read_from_buffer() as a fifth argument, turning the read method into a nop. The change is fundamentally flawed, as it breaks the driver. Signed-off-by: Oliver Neukum Cc: stable Link: https://lore.kernel.org/r/20241007094004.242122-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/yurex.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) --- a/drivers/usb/misc/yurex.c +++ b/drivers/usb/misc/yurex.c @@ -34,8 +34,6 @@ #define YUREX_BUF_SIZE 8 #define YUREX_WRITE_TIMEOUT (HZ*2) -#define MAX_S64_STRLEN 20 /* {-}922337203685477580{7,8} */ - /* table of devices that work with this driver */ static struct usb_device_id yurex_table[] = { { USB_DEVICE(YUREX_VENDOR_ID, YUREX_PRODUCT_ID) }, @@ -402,7 +400,8 @@ static ssize_t yurex_read(struct file *f { struct usb_yurex *dev; int len = 0; - char in_buffer[MAX_S64_STRLEN]; + char in_buffer[20]; + unsigned long flags; dev = file->private_data; @@ -412,16 +411,14 @@ static ssize_t yurex_read(struct file *f return -ENODEV; } - if (WARN_ON_ONCE(dev->bbu > S64_MAX || dev->bbu < S64_MIN)) { - mutex_unlock(&dev->io_mutex); - return -EIO; - } - - spin_lock_irq(&dev->lock); - scnprintf(in_buffer, MAX_S64_STRLEN, "%lld\n", dev->bbu); - spin_unlock_irq(&dev->lock); + spin_lock_irqsave(&dev->lock, flags); + len = snprintf(in_buffer, 20, "%lld\n", dev->bbu); + spin_unlock_irqrestore(&dev->lock, flags); mutex_unlock(&dev->io_mutex); + if (WARN_ON_ONCE(len >= sizeof(in_buffer))) + return -EIO; + return simple_read_from_buffer(buffer, count, ppos, in_buffer, len); }