From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: mm-commits@vger.kernel.org, stable@vger.kernel.org,
kees@kernel.org, andy@kernel.org, bartosz.golaszewski@linaro.org
Subject: Re: + lib-string_helpers-fix-potential-snprintf-output-truncation.patch added to mm-hotfixes-unstable branch
Date: Wed, 23 Oct 2024 20:27:40 -0700 [thread overview]
Message-ID: <20241023202740.ddcdbbe38b5fd46e619e2c44@linux-foundation.org> (raw)
In-Reply-To: <601574d94d05e580548256d6c46e1d3d38c6f132.camel@HansenPartnership.com>
On Wed, 23 Oct 2024 23:08:46 -0400 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > The output of ".%03u" with the unsigned int in range [0, 4294966295]
> > may get truncated if the target buffer is not 12 bytes.
>
> I think we all agree the explanation isn't accurate: remainder will be
> between 0-999 (not range [0, 4294966295]) which means that the string
> will only ever be 5 bytes (including leading zero).
>
> This might be required to correct a compiler false warning, but if it
> is applied, the patch description should say this.
>
Thanks, I've added a note-to-self that a new version is expected.
prev parent reply other threads:[~2024-10-24 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 2:52 + lib-string_helpers-fix-potential-snprintf-output-truncation.patch added to mm-hotfixes-unstable branch Andrew Morton
2024-10-24 3:08 ` James Bottomley
2024-10-24 3:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023202740.ddcdbbe38b5fd46e619e2c44@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=kees@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox