From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA69A79C4; Thu, 24 Oct 2024 09:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729763249; cv=none; b=ZObZ8oVf2xf7EDHaLUIOZCGsl3duxWk5yDAhJ/yutuNtNc6EeL3Ju+CHc6/OgiSFlFzYfLpqNj7mOmA8ZD4VkeDI86Jlf8Aa4mCbvIeSDz81BeAhyKWVIvGQWWpAWq7UfHqWGqEkvUv+OJfKzmWGN4nFkX22hbVcpaGrEx8DmdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729763249; c=relaxed/simple; bh=4Xd9flZBNjg4ZFP11yWd6ull8gJEasRSLCN7/xDE1T8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lqu2r3kbMkcuBQJ+KUEKwWo/3dJMqgbrGhV9fY/ADL6vkBk8mLXyKi1jCeSf//IyDpO2NP7HNNYWQmlz0BsV86Zym2lejFx6wLWNJcwXITf+oEtFqi1U0kXzabP79P+uv9tr2hD5aIRCOGJT6DfsZ2HnZtb4LJSR4bE9sCPImuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1jcQDXOb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1jcQDXOb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2E67C4CECD; Thu, 24 Oct 2024 09:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1729763249; bh=4Xd9flZBNjg4ZFP11yWd6ull8gJEasRSLCN7/xDE1T8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1jcQDXObT2VzXlLw2uVdZCr+y2DuY4ywLdsP92gDkq215zkAzzYt9/zDcKB7jO1pc BxitZahtp0qaQrdEaSvddSdN+nL6nDpxzdvb1goOVfEQ9XQBoUjgQVahxuZMSCNA9d DAnXd9BsV5Wk6ifI73XieB9AUHmMWsarL1ISWDGw= Date: Thu, 24 Oct 2024 11:47:18 +0200 From: Greg KH To: jason-jh.lin@mediatek.com Cc: Saravana Kannan , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Seiya Wang , Singo Chang Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Message-ID: <2024102406-shore-refurbish-767a@gregkh> References: <20241024-fixup-5-15-v1-1-74d360bd3002@mediatek.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241024-fixup-5-15-v1-1-74d360bd3002@mediatek.com> On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote: > From: "Jason-JH.Lin" > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200. > > Reason for revert: > 1. The commit [1] does not land on linux-5.15, so this patch does not > fix anything. > > 2. Since the fw_device improvements series [2] does not land on > linux-5.15, using device_set_fwnode() causes the panel to flash during > bootup. > > Incorrect link management may lead to incorrect device initialization, > affecting firmware node links and consumer relationships. > The fwnode setting of panel to the DSI device would cause a DSI > initialization error without series[2], so this patch was reverted to > avoid using the incomplete fw_devlink functionality. > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust") > [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com > > Signed-off-by: Jason-JH.Lin > --- > drivers/gpu/drm/drm_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 24606b632009..468a3a7cb6a5 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, > return dsi; > } > > - device_set_node(&dsi->dev, of_fwnode_handle(info->node)); > + dsi->dev.of_node = info->node; > dsi->channel = info->channel; > strlcpy(dsi->name, info->type, sizeof(dsi->name)); > > > --- > base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf > change-id: 20241024-fixup-5-15-5fdd68dae707 > > Best regards, > -- > Jason-JH.Lin > > > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.