From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
Cc: "saravanak@google.com" <saravanak@google.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Seiya Wang (王迺君)" <seiya.wang@mediatek.com>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>
Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
Date: Mon, 28 Oct 2024 07:33:06 +0100 [thread overview]
Message-ID: <2024102801-canopy-cruelness-ee23@gregkh> (raw)
In-Reply-To: <0e2fa50d4eee77f310362248cb2f95457ba341ad.camel@mediatek.com>
On Mon, Oct 28, 2024 at 06:08:15AM +0000, Jason-JH Lin (林睿祥) wrote:
> On Mon, 2024-10-28 at 06:38 +0100, Greg KH wrote:
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >
> >
> > On Thu, Oct 24, 2024 at 06:30:01PM +0800, Jason-JH.Lin via B4 Relay
> > wrote:
> > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > >
> > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > >
> > > Reason for revert:
> > > 1. The commit [1] does not land on linux-5.15, so this patch does
> > > not
> > > fix anything.
> > >
> > > 2. Since the fw_device improvements series [2] does not land on
> > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > during
> > > bootup.
> > >
> > > Incorrect link management may lead to incorrect device
> > > initialization,
> > > affecting firmware node links and consumer relationships.
> > > The fwnode setting of panel to the DSI device would cause a DSI
> > > initialization error without series[2], so this patch was reverted
> > > to
> > > avoid using the incomplete fw_devlink functionality.
> > >
> > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > detection more robust")
> > > [2] Link:
> > > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > >
> > > Cc: stable@vger.kernel.org # 5.15.169
> >
> > What about 5.10.y and 5.4.y as well? Aren't those also affected?
>
> Oh, Yes.
>
> I'll send v3 for these versions as well.
Thank you.
> BTW, how can I know what other branches should I revert the patch as
> well? Just in case I missed it in another branch.
You can look at all the branches to verify if it has been applied or
not. There are some tools that do this for you, I use the one I created
that can be found at:
https://git.sr.ht/~gregkh/linux-stable_commit_tree
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-28 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 10:30 [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Jason-JH.Lin via B4 Relay
2024-10-28 5:38 ` Greg KH
2024-10-28 6:08 ` Jason-JH Lin (林睿祥)
2024-10-28 6:32 ` Jason-JH Lin (林睿祥)
2024-10-28 6:33 ` gregkh [this message]
2024-10-29 1:17 ` Jason-JH Lin (林睿祥)
-- strict thread matches above, loose matches on Subject: below --
2024-10-24 9:37 Jason-JH.Lin via B4 Relay
2024-10-24 9:47 ` Greg KH
2024-10-24 10:16 ` Jason-JH Lin (林睿祥)
2024-10-24 10:23 ` gregkh
2024-10-28 2:38 ` Jason-JH Lin (林睿祥)
2024-10-28 5:26 ` gregkh
2024-10-28 6:02 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102801-canopy-cruelness-ee23@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=saravanak@google.com \
--cc=seiya.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox