public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
@ 2024-10-24  9:37 Jason-JH.Lin via B4 Relay
  2024-10-24  9:47 ` Greg KH
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin via B4 Relay @ 2024-10-24  9:37 UTC (permalink / raw)
  To: Saravana Kannan, stable
  Cc: linux-kernel, Seiya Wang, Jason-JH.Lin, Singo Chang

From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>

This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.

Reason for revert:
1. The commit [1] does not land on linux-5.15, so this patch does not
fix anything.

2. Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during
bootup.

Incorrect link management may lead to incorrect device initialization,
affecting firmware node links and consumer relationships.
The fwnode setting of panel to the DSI device would cause a DSI
initialization error without series[2], so this patch was reverted to
avoid using the incomplete fw_devlink functionality.

[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
[2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 24606b632009..468a3a7cb6a5 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
 		return dsi;
 	}
 
-	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
+	dsi->dev.of_node = info->node;
 	dsi->channel = info->channel;
 	strlcpy(dsi->name, info->type, sizeof(dsi->name));
 

---
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
change-id: 20241024-fixup-5-15-5fdd68dae707

Best regards,
-- 
Jason-JH.Lin <jason-jh.lin@mediatek.com>



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-24  9:37 Jason-JH.Lin via B4 Relay
@ 2024-10-24  9:47 ` Greg KH
  2024-10-24 10:16   ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2024-10-24  9:47 UTC (permalink / raw)
  To: jason-jh.lin
  Cc: Saravana Kannan, stable, linux-kernel, Seiya Wang, Singo Chang

On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote:
> From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> 
> This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> 
> Reason for revert:
> 1. The commit [1] does not land on linux-5.15, so this patch does not
> fix anything.
> 
> 2. Since the fw_device improvements series [2] does not land on
> linux-5.15, using device_set_fwnode() causes the panel to flash during
> bootup.
> 
> Incorrect link management may lead to incorrect device initialization,
> affecting firmware node links and consumer relationships.
> The fwnode setting of panel to the DSI device would cause a DSI
> initialization error without series[2], so this patch was reverted to
> avoid using the incomplete fw_devlink functionality.
> 
> [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
> [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index 24606b632009..468a3a7cb6a5 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
>  		return dsi;
>  	}
>  
> -	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> +	dsi->dev.of_node = info->node;
>  	dsi->channel = info->channel;
>  	strlcpy(dsi->name, info->type, sizeof(dsi->name));
>  
> 
> ---
> base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
> change-id: 20241024-fixup-5-15-5fdd68dae707
> 
> Best regards,
> -- 
> Jason-JH.Lin <jason-jh.lin@mediatek.com>
> 
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-24  9:47 ` Greg KH
@ 2024-10-24 10:16   ` Jason-JH Lin (林睿祥)
  2024-10-24 10:23     ` gregkh
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-24 10:16 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	stable@vger.kernel.org, Seiya Wang (王迺君),
	Singo Chang (張興國)

Hi Greg,

Thanks for your information.

On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay
> wrote:
> > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > 
> > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > 
> > Reason for revert:
> > 1. The commit [1] does not land on linux-5.15, so this patch does
> not
> > fix anything.
> > 
> > 2. Since the fw_device improvements series [2] does not land on
> > linux-5.15, using device_set_fwnode() causes the panel to flash
> during
> > bootup.
> > 
> > Incorrect link management may lead to incorrect device
> initialization,
> > affecting firmware node links and consumer relationships.
> > The fwnode setting of panel to the DSI device would cause a DSI
> > initialization error without series[2], so this patch was reverted
> to
> > avoid using the incomplete fw_devlink functionality.
> > 
> > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> detection more robust")
> > [2] Link: 
> https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > 

Please don't mind me make a confirmation.
I just need to add this line here and send it again, right?

Cc: <stable@vger.kernel.org> #5.15.169

> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---

Regards,
Jason-JH.Lin

> >  drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> b/drivers/gpu/drm/drm_mipi_dsi.c
> > index 24606b632009..468a3a7cb6a5 100644
> > --- a/drivers/gpu/drm/drm_mipi_dsi.c
> > +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> mipi_dsi_host *host,
> >  return dsi;
> >  }
> >  
> > -device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> > +dsi->dev.of_node = info->node;
> >  dsi->channel = info->channel;
> >  strlcpy(dsi->name, info->type, sizeof(dsi->name));
> >  
> > 
> > ---
> > base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
> > change-id: 20241024-fixup-5-15-5fdd68dae707
> > 
> > Best regards,
> > -- 
> > Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > 
> > 
> > 
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-24 10:16   ` Jason-JH Lin (林睿祥)
@ 2024-10-24 10:23     ` gregkh
  2024-10-28  2:38       ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: gregkh @ 2024-10-24 10:23 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥)
  Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	stable@vger.kernel.org, Seiya Wang (王迺君),
	Singo Chang (張興國)

On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
> Hi Greg,
> 
> Thanks for your information.
> 
> On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay
> > wrote:
> > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > > 
> > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > 
> > > Reason for revert:
> > > 1. The commit [1] does not land on linux-5.15, so this patch does
> > not
> > > fix anything.
> > > 
> > > 2. Since the fw_device improvements series [2] does not land on
> > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > during
> > > bootup.
> > > 
> > > Incorrect link management may lead to incorrect device
> > initialization,
> > > affecting firmware node links and consumer relationships.
> > > The fwnode setting of panel to the DSI device would cause a DSI
> > > initialization error without series[2], so this patch was reverted
> > to
> > > avoid using the incomplete fw_devlink functionality.
> > > 
> > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > detection more robust")
> > > [2] Link: 
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > 
> 
> Please don't mind me make a confirmation.
> I just need to add this line here and send it again, right?
> 
> Cc: <stable@vger.kernel.org> #5.15.169

Yes.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
@ 2024-10-24 10:30 Jason-JH.Lin via B4 Relay
  2024-10-28  5:38 ` Greg KH
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin via B4 Relay @ 2024-10-24 10:30 UTC (permalink / raw)
  To: stable, Saravana Kannan; +Cc: Greg KH, Seiya Wang, Jason-JH.Lin, Singo Chang

From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>

This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.

Reason for revert:
1. The commit [1] does not land on linux-5.15, so this patch does not
fix anything.

2. Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during
bootup.

Incorrect link management may lead to incorrect device initialization,
affecting firmware node links and consumer relationships.
The fwnode setting of panel to the DSI device would cause a DSI
initialization error without series[2], so this patch was reverted to
avoid using the incomplete fw_devlink functionality.

[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
[2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com

Cc: stable@vger.kernel.org # 5.15.169
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 24606b632009..468a3a7cb6a5 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
 		return dsi;
 	}
 
-	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
+	dsi->dev.of_node = info->node;
 	dsi->channel = info->channel;
 	strlcpy(dsi->name, info->type, sizeof(dsi->name));
 

---
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
change-id: 20241024-fixup-5-15-5fdd68dae707

Best regards,
-- 
Jason-JH.Lin <jason-jh.lin@mediatek.com>



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-24 10:23     ` gregkh
@ 2024-10-28  2:38       ` Jason-JH Lin (林睿祥)
  2024-10-28  5:26         ` gregkh
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-28  2:38 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	stable@vger.kernel.org, Seiya Wang (王迺君),
	Singo Chang (張興國)

On Thu, 2024-10-24 at 12:23 +0200, gregkh@linuxfoundation.org wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
> > Hi Greg,
> > 
> > Thanks for your information.
> > 
> > On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
> > >   
> > > External email : Please do not click links or open attachments
> until
> > > you have verified the sender or the content.
> > >  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
> Relay
> > > wrote:
> > > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > > > 
> > > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > > 
> > > > Reason for revert:
> > > > 1. The commit [1] does not land on linux-5.15, so this patch
> does
> > > not
> > > > fix anything.
> > > > 
> > > > 2. Since the fw_device improvements series [2] does not land on
> > > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > during
> > > > bootup.
> > > > 
> > > > Incorrect link management may lead to incorrect device
> > > initialization,
> > > > affecting firmware node links and consumer relationships.
> > > > The fwnode setting of panel to the DSI device would cause a DSI
> > > > initialization error without series[2], so this patch was
> reverted
> > > to
> > > > avoid using the incomplete fw_devlink functionality.
> > > > 
> > > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > detection more robust")
> > > > [2] Link: 
> > > 
> https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > > 
> > 
> > Please don't mind me make a confirmation.
> > I just need to add this line here and send it again, right?
> > 
> > Cc: <stable@vger.kernel.org> #5.15.169
> 
> Yes.

Hi Greg,

Thanks for your confirmation!

I've sent the patch again without adding `v2` after the [PATCH]:
https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.com
Would that be fine with you?

Regards,
Jason-JH.Lin


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  2:38       ` Jason-JH Lin (林睿祥)
@ 2024-10-28  5:26         ` gregkh
  2024-10-28  6:02           ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: gregkh @ 2024-10-28  5:26 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥)
  Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	stable@vger.kernel.org, Seiya Wang (王迺君),
	Singo Chang (張興國)

On Mon, Oct 28, 2024 at 02:38:49AM +0000, Jason-JH Lin (林睿祥) wrote:
> On Thu, 2024-10-24 at 12:23 +0200, gregkh@linuxfoundation.org wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
> > > Hi Greg,
> > > 
> > > Thanks for your information.
> > > 
> > > On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
> > > >   
> > > > External email : Please do not click links or open attachments
> > until
> > > > you have verified the sender or the content.
> > > >  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
> > Relay
> > > > wrote:
> > > > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > > > > 
> > > > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > > > 
> > > > > Reason for revert:
> > > > > 1. The commit [1] does not land on linux-5.15, so this patch
> > does
> > > > not
> > > > > fix anything.
> > > > > 
> > > > > 2. Since the fw_device improvements series [2] does not land on
> > > > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > > during
> > > > > bootup.
> > > > > 
> > > > > Incorrect link management may lead to incorrect device
> > > > initialization,
> > > > > affecting firmware node links and consumer relationships.
> > > > > The fwnode setting of panel to the DSI device would cause a DSI
> > > > > initialization error without series[2], so this patch was
> > reverted
> > > > to
> > > > > avoid using the incomplete fw_devlink functionality.
> > > > > 
> > > > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > > detection more robust")
> > > > > [2] Link: 
> > > > 
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > > > 
> > > 
> > > Please don't mind me make a confirmation.
> > > I just need to add this line here and send it again, right?
> > > 
> > > Cc: <stable@vger.kernel.org> #5.15.169
> > 
> > Yes.
> 
> Hi Greg,
> 
> Thanks for your confirmation!
> 
> I've sent the patch again without adding `v2` after the [PATCH]:
> https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.com
> Would that be fine with you?

But it is a v2 patch, why not mark it as such?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-24 10:30 [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Jason-JH.Lin via B4 Relay
@ 2024-10-28  5:38 ` Greg KH
  2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2024-10-28  5:38 UTC (permalink / raw)
  To: jason-jh.lin; +Cc: stable, Saravana Kannan, Seiya Wang, Singo Chang

On Thu, Oct 24, 2024 at 06:30:01PM +0800, Jason-JH.Lin via B4 Relay wrote:
> From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> 
> This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> 
> Reason for revert:
> 1. The commit [1] does not land on linux-5.15, so this patch does not
> fix anything.
> 
> 2. Since the fw_device improvements series [2] does not land on
> linux-5.15, using device_set_fwnode() causes the panel to flash during
> bootup.
> 
> Incorrect link management may lead to incorrect device initialization,
> affecting firmware node links and consumer relationships.
> The fwnode setting of panel to the DSI device would cause a DSI
> initialization error without series[2], so this patch was reverted to
> avoid using the incomplete fw_devlink functionality.
> 
> [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
> [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> 
> Cc: stable@vger.kernel.org # 5.15.169

What about 5.10.y and 5.4.y as well?  Aren't those also affected?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  5:26         ` gregkh
@ 2024-10-28  6:02           ` Jason-JH Lin (林睿祥)
  0 siblings, 0 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-28  6:02 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	stable@vger.kernel.org, Seiya Wang (王迺君),
	Singo Chang (張興國)

[snip]
> > > > 
> > > > Please don't mind me make a confirmation.
> > > > I just need to add this line here and send it again, right?
> > > > 
> > > > Cc: <stable@vger.kernel.org> #5.15.169
> > > 
> > > Yes.
> > 
> > Hi Greg,
> > 
> > Thanks for your confirmation!
> > 
> > I've sent the patch again without adding `v2` after the [PATCH]:
> > 
https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.com
> > Would that be fine with you?
> 
> But it is a v2 patch, why not mark it as such?

I thought correcting format is not changing commit message or
modification, so I didn't increase the version number.

Anyway, I've sent the v2 again:

https://lore.kernel.org/all/20241028-fixup-5-15-v2-1-40216f0fe383@mediatek.com

Regards,
Jason-JH.Lin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  5:38 ` Greg KH
@ 2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
  2024-10-28  6:32     ` Jason-JH Lin (林睿祥)
  2024-10-28  6:33     ` gregkh
  0 siblings, 2 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-28  6:08 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: saravanak@google.com, stable@vger.kernel.org,
	Seiya Wang (王迺君),
	Singo Chang (張興國)

On Mon, 2024-10-28 at 06:38 +0100, Greg KH wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, Oct 24, 2024 at 06:30:01PM +0800, Jason-JH.Lin via B4 Relay
> wrote:
> > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > 
> > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > 
> > Reason for revert:
> > 1. The commit [1] does not land on linux-5.15, so this patch does
> > not
> > fix anything.
> > 
> > 2. Since the fw_device improvements series [2] does not land on
> > linux-5.15, using device_set_fwnode() causes the panel to flash
> > during
> > bootup.
> > 
> > Incorrect link management may lead to incorrect device
> > initialization,
> > affecting firmware node links and consumer relationships.
> > The fwnode setting of panel to the DSI device would cause a DSI
> > initialization error without series[2], so this patch was reverted
> > to
> > avoid using the incomplete fw_devlink functionality.
> > 
> > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > detection more robust")
> > [2] Link: 
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > 
> > Cc: stable@vger.kernel.org # 5.15.169
> 
> What about 5.10.y and 5.4.y as well?  Aren't those also affected?

Oh, Yes.

I'll send v3 for these versions as well.

BTW, how can I know what other branches should I revert the patch as
well? Just in case I missed it in another branch.

Regards,
Jason-JH.Lin

> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
@ 2024-10-28  6:32     ` Jason-JH Lin (林睿祥)
  2024-10-28  6:33     ` gregkh
  1 sibling, 0 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-28  6:32 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: saravanak@google.com, stable@vger.kernel.org,
	Seiya Wang (王迺君),
	Singo Chang (張興國)

[snip]
> > > 
> > > Cc: stable@vger.kernel.org # 5.15.169
> > 
> > What about 5.10.y and 5.4.y as well?  Aren't those also affected?
> 
> Oh, Yes.
> 
> I'll send v3 for these versions as well.
> 
> BTW, how can I know what other branches should I revert the patch as
> well? Just in case I missed it in another branch.
> 

I think I found that in the longterm release kernel version:
https://kernel.org/category/releases.html

I'll send the v3 soon.
Thanks!

Regards,
Jason-JH.Lin

> Regards,
> Jason-JH.Lin
> 
> > 
> > thanks,
> > 
> > greg k-h

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
  2024-10-28  6:32     ` Jason-JH Lin (林睿祥)
@ 2024-10-28  6:33     ` gregkh
  2024-10-29  1:17       ` Jason-JH Lin (林睿祥)
  1 sibling, 1 reply; 13+ messages in thread
From: gregkh @ 2024-10-28  6:33 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥)
  Cc: saravanak@google.com, stable@vger.kernel.org,
	Seiya Wang (王迺君),
	Singo Chang (張興國)

On Mon, Oct 28, 2024 at 06:08:15AM +0000, Jason-JH Lin (林睿祥) wrote:
> On Mon, 2024-10-28 at 06:38 +0100, Greg KH wrote:
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> > 
> > 
> > On Thu, Oct 24, 2024 at 06:30:01PM +0800, Jason-JH.Lin via B4 Relay
> > wrote:
> > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > > 
> > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > 
> > > Reason for revert:
> > > 1. The commit [1] does not land on linux-5.15, so this patch does
> > > not
> > > fix anything.
> > > 
> > > 2. Since the fw_device improvements series [2] does not land on
> > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > during
> > > bootup.
> > > 
> > > Incorrect link management may lead to incorrect device
> > > initialization,
> > > affecting firmware node links and consumer relationships.
> > > The fwnode setting of panel to the DSI device would cause a DSI
> > > initialization error without series[2], so this patch was reverted
> > > to
> > > avoid using the incomplete fw_devlink functionality.
> > > 
> > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > detection more robust")
> > > [2] Link: 
> > > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > 
> > > Cc: stable@vger.kernel.org # 5.15.169
> > 
> > What about 5.10.y and 5.4.y as well?  Aren't those also affected?
> 
> Oh, Yes.
> 
> I'll send v3 for these versions as well.

Thank you.

> BTW, how can I know what other branches should I revert the patch as
> well? Just in case I missed it in another branch.

You can look at all the branches to verify if it has been applied or
not.  There are some tools that do this for you, I use the one I created
that can be found at:
	https://git.sr.ht/~gregkh/linux-stable_commit_tree

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
  2024-10-28  6:33     ` gregkh
@ 2024-10-29  1:17       ` Jason-JH Lin (林睿祥)
  0 siblings, 0 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-10-29  1:17 UTC (permalink / raw)
  To: gregkh@linuxfoundation.org
  Cc: saravanak@google.com, stable@vger.kernel.org,
	Seiya Wang (王迺君),
	Singo Chang (張興國)


[snip]

> > > > Cc: stable@vger.kernel.org # 5.15.169
> > > 
> > > What about 5.10.y and 5.4.y as well?  Aren't those also affected?
> > 
> > Oh, Yes.
> > 
> > I'll send v3 for these versions as well.
> 
> Thank you.
> 
> > BTW, how can I know what other branches should I revert the patch
> > as
> > well? Just in case I missed it in another branch.
> 
> You can look at all the branches to verify if it has been applied or
> not.  There are some tools that do this for you, I use the one I
> created
> that can be found at:
>         
> https://urldefense.com/v3/__https://git.sr.ht/*gregkh/linux-stable_commit_tree__;fg!!CTRNKA9wMg0ARbw!kh1hunnDlc3nrO0hdATYQajTIGGhGwBOvDLNBUV7UqVBjsHZhW6BIl5H2XyJp7yD4Tb6rz5Ahe6sSE8R_8ZCZRd1IKZN$
> 
> 

Got it. Thanks for your help!

Regards,
Jason-JH.Lin

> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-10-29  1:18 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-24 10:30 [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Jason-JH.Lin via B4 Relay
2024-10-28  5:38 ` Greg KH
2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
2024-10-28  6:32     ` Jason-JH Lin (林睿祥)
2024-10-28  6:33     ` gregkh
2024-10-29  1:17       ` Jason-JH Lin (林睿祥)
  -- strict thread matches above, loose matches on Subject: below --
2024-10-24  9:37 Jason-JH.Lin via B4 Relay
2024-10-24  9:47 ` Greg KH
2024-10-24 10:16   ` Jason-JH Lin (林睿祥)
2024-10-24 10:23     ` gregkh
2024-10-28  2:38       ` Jason-JH Lin (林睿祥)
2024-10-28  5:26         ` gregkh
2024-10-28  6:02           ` Jason-JH Lin (林睿祥)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox