public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
@ 2024-10-24 10:30 Jason-JH.Lin via B4 Relay
  2024-10-28  5:38 ` Greg KH
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin via B4 Relay @ 2024-10-24 10:30 UTC (permalink / raw)
  To: stable, Saravana Kannan; +Cc: Greg KH, Seiya Wang, Jason-JH.Lin, Singo Chang

From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>

This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.

Reason for revert:
1. The commit [1] does not land on linux-5.15, so this patch does not
fix anything.

2. Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during
bootup.

Incorrect link management may lead to incorrect device initialization,
affecting firmware node links and consumer relationships.
The fwnode setting of panel to the DSI device would cause a DSI
initialization error without series[2], so this patch was reverted to
avoid using the incomplete fw_devlink functionality.

[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
[2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com

Cc: stable@vger.kernel.org # 5.15.169
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 24606b632009..468a3a7cb6a5 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
 		return dsi;
 	}
 
-	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
+	dsi->dev.of_node = info->node;
 	dsi->channel = info->channel;
 	strlcpy(dsi->name, info->type, sizeof(dsi->name));
 

---
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
change-id: 20241024-fixup-5-15-5fdd68dae707

Best regards,
-- 
Jason-JH.Lin <jason-jh.lin@mediatek.com>



^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
@ 2024-10-24  9:37 Jason-JH.Lin via B4 Relay
  2024-10-24  9:47 ` Greg KH
  0 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin via B4 Relay @ 2024-10-24  9:37 UTC (permalink / raw)
  To: Saravana Kannan, stable
  Cc: linux-kernel, Seiya Wang, Jason-JH.Lin, Singo Chang

From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>

This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.

Reason for revert:
1. The commit [1] does not land on linux-5.15, so this patch does not
fix anything.

2. Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during
bootup.

Incorrect link management may lead to incorrect device initialization,
affecting firmware node links and consumer relationships.
The fwnode setting of panel to the DSI device would cause a DSI
initialization error without series[2], so this patch was reverted to
avoid using the incomplete fw_devlink functionality.

[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
[2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index 24606b632009..468a3a7cb6a5 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
 		return dsi;
 	}
 
-	device_set_node(&dsi->dev, of_fwnode_handle(info->node));
+	dsi->dev.of_node = info->node;
 	dsi->channel = info->channel;
 	strlcpy(dsi->name, info->type, sizeof(dsi->name));
 

---
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf
change-id: 20241024-fixup-5-15-5fdd68dae707

Best regards,
-- 
Jason-JH.Lin <jason-jh.lin@mediatek.com>



^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-10-29  1:18 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-24 10:30 [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Jason-JH.Lin via B4 Relay
2024-10-28  5:38 ` Greg KH
2024-10-28  6:08   ` Jason-JH Lin (林睿祥)
2024-10-28  6:32     ` Jason-JH Lin (林睿祥)
2024-10-28  6:33     ` gregkh
2024-10-29  1:17       ` Jason-JH Lin (林睿祥)
  -- strict thread matches above, loose matches on Subject: below --
2024-10-24  9:37 Jason-JH.Lin via B4 Relay
2024-10-24  9:47 ` Greg KH
2024-10-24 10:16   ` Jason-JH Lin (林睿祥)
2024-10-24 10:23     ` gregkh
2024-10-28  2:38       ` Jason-JH Lin (林睿祥)
2024-10-28  5:26         ` gregkh
2024-10-28  6:02           ` Jason-JH Lin (林睿祥)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox