From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"saravanak@google.com" <saravanak@google.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Seiya Wang (王迺君)" <seiya.wang@mediatek.com>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>
Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
Date: Mon, 28 Oct 2024 06:26:04 +0100 [thread overview]
Message-ID: <2024102855-untitled-unfixed-2b9d@gregkh> (raw)
In-Reply-To: <ddc5f179dfa8445e2b25ae0c6e382550d45bbbd3.camel@mediatek.com>
On Mon, Oct 28, 2024 at 02:38:49AM +0000, Jason-JH Lin (林睿祥) wrote:
> On Thu, 2024-10-24 at 12:23 +0200, gregkh@linuxfoundation.org wrote:
> >
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> > On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
> > > Hi Greg,
> > >
> > > Thanks for your information.
> > >
> > > On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
> > > >
> > > > External email : Please do not click links or open attachments
> > until
> > > > you have verified the sender or the content.
> > > > On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
> > Relay
> > > > wrote:
> > > > > From: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
> > > > >
> > > > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > > >
> > > > > Reason for revert:
> > > > > 1. The commit [1] does not land on linux-5.15, so this patch
> > does
> > > > not
> > > > > fix anything.
> > > > >
> > > > > 2. Since the fw_device improvements series [2] does not land on
> > > > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > > during
> > > > > bootup.
> > > > >
> > > > > Incorrect link management may lead to incorrect device
> > > > initialization,
> > > > > affecting firmware node links and consumer relationships.
> > > > > The fwnode setting of panel to the DSI device would cause a DSI
> > > > > initialization error without series[2], so this patch was
> > reverted
> > > > to
> > > > > avoid using the incomplete fw_devlink functionality.
> > > > >
> > > > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > > detection more robust")
> > > > > [2] Link:
> > > >
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > > >
> > >
> > > Please don't mind me make a confirmation.
> > > I just need to add this line here and send it again, right?
> > >
> > > Cc: <stable@vger.kernel.org> #5.15.169
> >
> > Yes.
>
> Hi Greg,
>
> Thanks for your confirmation!
>
> I've sent the patch again without adding `v2` after the [PATCH]:
> https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.com
> Would that be fine with you?
But it is a v2 patch, why not mark it as such?
next prev parent reply other threads:[~2024-10-28 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:37 [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device" Jason-JH.Lin via B4 Relay
2024-10-24 9:47 ` Greg KH
2024-10-24 10:16 ` Jason-JH Lin (林睿祥)
2024-10-24 10:23 ` gregkh
2024-10-28 2:38 ` Jason-JH Lin (林睿祥)
2024-10-28 5:26 ` gregkh [this message]
2024-10-28 6:02 ` Jason-JH Lin (林睿祥)
-- strict thread matches above, loose matches on Subject: below --
2024-10-24 10:30 Jason-JH.Lin via B4 Relay
2024-10-28 5:38 ` Greg KH
2024-10-28 6:08 ` Jason-JH Lin (林睿祥)
2024-10-28 6:32 ` Jason-JH Lin (林睿祥)
2024-10-28 6:33 ` gregkh
2024-10-29 1:17 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102855-untitled-unfixed-2b9d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=seiya.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox