From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Faisal Hassan <quic_faisalh@quicinc.com>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] xhci: Fix Link TRB DMA in command ring stopped completion event
Date: Tue, 29 Oct 2024 04:22:25 +0100 [thread overview]
Message-ID: <2024102918-visiting-oboe-dc64@gregkh> (raw)
In-Reply-To: <f9a2eb47-512e-4718-a83a-4742e09be85b@linux.intel.com>
On Thu, Oct 24, 2024 at 05:06:44PM +0300, Mathias Nyman wrote:
> On 22.10.2024 18.56, Faisal Hassan wrote:
> > During the aborting of a command, the software receives a command
> > completion event for the command ring stopped, with the TRB pointing
> > to the next TRB after the aborted command.
> >
> > If the command we abort is located just before the Link TRB in the
> > command ring, then during the 'command ring stopped' completion event,
> > the xHC gives the Link TRB in the event's cmd DMA, which causes a
> > mismatch in handling command completion event.
> >
> > To address this situation, move the 'command ring stopped' completion
> > event check slightly earlier, since the specific command it stopped
> > on isn't of significant concern.
> >
> > Fixes: 7f84eef0dafb ("USB: xhci: No-op command queueing and irq handler.")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Faisal Hassan <quic_faisalh@quicinc.com>
>
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
> Greg, would you like to take this directly to usb-linus (6.12)?
> If not I'll send it as part of series to usb-next later
Sure, I'll take it now, thanks.
greg k-h
prev parent reply other threads:[~2024-10-29 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 15:56 [PATCH v3] xhci: Fix Link TRB DMA in command ring stopped completion event Faisal Hassan
2024-10-24 14:06 ` Mathias Nyman
2024-10-29 3:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102918-visiting-oboe-dc64@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=quic_faisalh@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox