From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863724436E; Fri, 1 Nov 2024 14:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730469767; cv=none; b=tJMIP2cSrwTNnG8iKia9jz87A3xUbA3rWzZ7KDgDT+SuYbv0oTneLc3dnCBXv5+axxc3hxS8+MQQlYDnn87j8cmkKSIDiRSASp4xa1HG/pxbdaUYP7AduZ0112/vxXNE8tJqClmjAEXhwlh86YZ9yI/jbGWp1c+p++4vLuaWD8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730469767; c=relaxed/simple; bh=MsQ9V3sf5ngVZOnd60/14YeNO9J7P5KfgVF/8fNfJW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TEtc8vDFdlfeIIywHrARk+5hSBQ3XM4zqJkKPhGpq3tI451Y6Y22sJeUv2flRnve6c6ed5yp7rmrNJRaw/4NziEPOR9Um7bX55h/oBkUMW0e3IAgvBkf8EfNZpnrK21/v0JpPQAxmFXOYmpvBHLrSwpsacAdq0uca5vAqCX4cVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=e3yl7GYz; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="e3yl7GYz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730469765; x=1762005765; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MsQ9V3sf5ngVZOnd60/14YeNO9J7P5KfgVF/8fNfJW0=; b=e3yl7GYzZDTrshHQsLu+eX05qlDTqNZB1/MWLnPvyCmyFIeOnf11olOh h3Qs/hs+4AGuL/IJRH9QovpuEfabxQLpF8gzo7hjTYID1a20bB5Ka7pXR qcXosoeASWeyuVXViAHBoEeYzdDQIr/M0H+V3lEFSGim9GjPZqcnEUnuT KG7nPnr9Htw5Z23OREMx4yKDJmfXjNcs6vmOaSk5FfqgYu+LIGQw6aI8w FwAGm0XyrLh/rWoIm8IsQwWs/h532meApljnlP7pjqDkHj/ghrJ9zirhL KtpVfJqpzDoepxQ5GbCtqBzXAt+nGSx49cL9z/a/T0zlH2hlMiQQB5aZ/ g==; X-CSE-ConnectionGUID: JrZKD7WyRQa+L+u91lg1KQ== X-CSE-MsgGUID: MbjjSyGrTRqMTwLXtS/ZdA== X-IronPort-AV: E=McAfee;i="6700,10204,11243"; a="29654125" X-IronPort-AV: E=Sophos;i="6.11,250,1725346800"; d="scan'208";a="29654125" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2024 07:02:44 -0700 X-CSE-ConnectionGUID: rFT8x/NOQPa4sxUhjtTxQg== X-CSE-MsgGUID: UjNqDcWDTKClZxEyenorSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="87767855" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa003.jf.intel.com with ESMTP; 01 Nov 2024 07:02:41 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t6sEX-000hcH-2j; Fri, 01 Nov 2024 14:02:37 +0000 Date: Fri, 1 Nov 2024 22:02:09 +0800 From: kernel test robot To: George Rurikov , Christoph Hellwig Cc: oe-kbuild-all@lists.linux.dev, MrRurikov , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , Israel Rukshin , Max Gurtovoy , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, George Rurikov Subject: Re: [PATCH] nvme: rdma: Add check for queue in nvmet_rdma_cm_handler() Message-ID: <202411012136.hoMlvrTF-lkp@intel.com> References: <20241031173327.663-1-grurikov@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031173327.663-1-grurikov@gmail.com> Hi George, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.12-rc5 next-20241101] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/George-Rurikov/nvme-rdma-Add-check-for-queue-in-nvmet_rdma_cm_handler/20241101-013611 base: linus/master patch link: https://lore.kernel.org/r/20241031173327.663-1-grurikov%40gmail.com patch subject: [PATCH] nvme: rdma: Add check for queue in nvmet_rdma_cm_handler() config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20241101/202411012136.hoMlvrTF-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241101/202411012136.hoMlvrTF-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202411012136.hoMlvrTF-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/nvme/target/rdma.c: In function 'nvmet_rdma_cm_handler': >> drivers/nvme/target/rdma.c:1771:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 1771 | if (!queue) { | ^ drivers/nvme/target/rdma.c:1775:9: note: here 1775 | case RDMA_CM_EVENT_ADDR_CHANGE: | ^~~~ drivers/nvme/target/rdma.c:1785:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 1785 | if (!queue) { | ^ drivers/nvme/target/rdma.c:1789:9: note: here 1789 | case RDMA_CM_EVENT_DEVICE_REMOVAL: | ^~~~ drivers/nvme/target/rdma.c:1798:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 1798 | if (!queue) { | ^ drivers/nvme/target/rdma.c:1802:9: note: here 1802 | default: | ^~~~~~~ vim +1771 drivers/nvme/target/rdma.c 1752 1753 static int nvmet_rdma_cm_handler(struct rdma_cm_id *cm_id, 1754 struct rdma_cm_event *event) 1755 { 1756 struct nvmet_rdma_queue *queue = NULL; 1757 int ret = 0; 1758 1759 if (cm_id->qp) 1760 queue = cm_id->qp->qp_context; 1761 1762 pr_debug("%s (%d): status %d id %p\n", 1763 rdma_event_msg(event->event), event->event, 1764 event->status, cm_id); 1765 1766 switch (event->event) { 1767 case RDMA_CM_EVENT_CONNECT_REQUEST: 1768 ret = nvmet_rdma_queue_connect(cm_id, event); 1769 break; 1770 case RDMA_CM_EVENT_ESTABLISHED: > 1771 if (!queue) { 1772 nvmet_rdma_queue_established(queue); 1773 break; 1774 } 1775 case RDMA_CM_EVENT_ADDR_CHANGE: 1776 if (!queue) { 1777 struct nvmet_rdma_port *port = cm_id->context; 1778 1779 queue_delayed_work(nvmet_wq, &port->repair_work, 0); 1780 break; 1781 } 1782 fallthrough; 1783 case RDMA_CM_EVENT_DISCONNECTED: 1784 case RDMA_CM_EVENT_TIMEWAIT_EXIT: 1785 if (!queue) { 1786 nvmet_rdma_queue_disconnect(queue); 1787 break; 1788 } 1789 case RDMA_CM_EVENT_DEVICE_REMOVAL: 1790 ret = nvmet_rdma_device_removal(cm_id, queue); 1791 break; 1792 case RDMA_CM_EVENT_REJECTED: 1793 pr_debug("Connection rejected: %s\n", 1794 rdma_reject_msg(cm_id, event->status)); 1795 fallthrough; 1796 case RDMA_CM_EVENT_UNREACHABLE: 1797 case RDMA_CM_EVENT_CONNECT_ERROR: 1798 if (!queue) { 1799 nvmet_rdma_queue_connect_fail(cm_id, queue); 1800 break; 1801 } 1802 default: 1803 pr_err("received unrecognized RDMA CM event %d\n", 1804 event->event); 1805 break; 1806 } 1807 1808 return ret; 1809 } 1810 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki