From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45E41D9A48 for ; Tue, 5 Nov 2024 16:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730824964; cv=none; b=NLxOTiIAuLVBcLMyiV9xuJxRMl/5WLDv22TmWDfJgsGvPDlVRyJT24N3ErKe73sT4IRLSjkSxm3wwlxGsGZfqcdDbhIoKL5eQhRRlOs1DKyvGOJqd6FfwK91c98uJgYgdceGiImRrOAIFEa4XBs0N0djWWcY52CW2BV14Bdk41w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730824964; c=relaxed/simple; bh=Wo+xxgIgSTUDy8kZ9D1TFJbOwjIn27FdM769QTcKU88=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=lyIr096rT59GIEzfvkz6iULQUe95QQvk1/3qsWT0HZHGHqhsHPRT/35r0g81IljBygj8m7cyhLhANwPeLBXqSdN+/aCh7JLG/OHRmdyboFTm10ymTZanaIvooFon62j3h3Jd+SMCH19tHyofM9mR6jsG7p/g/w24PhjndVBP2Qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SHpb+rE9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SHpb+rE9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E8DAC4CECF; Tue, 5 Nov 2024 16:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730824964; bh=Wo+xxgIgSTUDy8kZ9D1TFJbOwjIn27FdM769QTcKU88=; h=Subject:To:Cc:From:Date:From; b=SHpb+rE9Mg9NvfymKBUmu8p5B7YDHcCn6uXXR8IxZiyCvJ6nB2M8Lf56Nhj0tlV0P JQ+2ZzEfTvHd10ilnB7j+BRIIxBmlvolJ+n6LiqtRfH60vkLoFDu7E9z8Uh9r23zv/ QLmmP2OAulm9Dw/OLbnSVqnzVcWrQ3yDd0L0hG4k= Subject: FAILED: patch "[PATCH] firmware: qcom: scm: suppress download mode error" failed to apply to 6.11-stable tree To: johan+linaro@kernel.org,andersson@kernel.org,quic_mojha@quicinc.com Cc: From: Date: Tue, 05 Nov 2024 17:42:26 +0100 Message-ID: <2024110526-driven-small-2a5c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.11-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.11.y git checkout FETCH_HEAD git cherry-pick -x d67907154808745b0fae5874edc7b0f78d33991c # git commit -s git send-email --to '' --in-reply-to '2024110526-driven-small-2a5c@gregkh' --subject-prefix 'PATCH 6.11.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d67907154808745b0fae5874edc7b0f78d33991c Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 2 Oct 2024 12:01:21 +0200 Subject: [PATCH] firmware: qcom: scm: suppress download mode error Stop spamming the logs with errors about missing mechanism for setting the so called download (or dump) mode for users that have not requested that feature to be enabled in the first place. This avoids the follow error being logged on boot as well as on shutdown when the feature it not available and download mode has not been enabled on the kernel command line: qcom_scm firmware:scm: No available mechanism for setting download mode Fixes: 79cb2cb8d89b ("firmware: qcom: scm: Disable SDI and write no dump to dump mode") Fixes: 781d32d1c970 ("firmware: qcom_scm: Clear download bit during reboot") Cc: Mukesh Ojha Cc: stable@vger.kernel.org # 6.4 Signed-off-by: Johan Hovold Reviewed-by: Mukesh Ojha Link: https://lore.kernel.org/r/20241002100122.18809-2-johan+linaro@kernel.org Signed-off-by: Bjorn Andersson diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 10986cb11ec0..e2ac595902ed 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -545,7 +545,7 @@ static void qcom_scm_set_download_mode(u32 dload_mode) } else if (__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_BOOT, QCOM_SCM_BOOT_SET_DLOAD_MODE)) { ret = __qcom_scm_set_dload_mode(__scm->dev, !!dload_mode); - } else { + } else if (dload_mode) { dev_err(__scm->dev, "No available mechanism for setting download mode\n"); }