From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B711DF24D; Wed, 6 Nov 2024 12:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730894889; cv=none; b=YsRFf6fzCdopcFLykAzp9JkIjHssgYddA1q3CF9pAzeaquZbdVzMcsqLZtLAMVB6/9RckKoDa2jWnD2NhtfQOF7qJFGcAuhFWBlgPoSLxIZa+LLgWYfKLYIxHKF5f6CklNErRJrHIYhCHcTmmgEsYJwbLPDtQxWWughgvqHsV+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730894889; c=relaxed/simple; bh=+fwIoVPk+oWWNS82mXLD4lf6cTbe4tZ3O8AdwAonA2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uFU6Ffq3QpM78aNHQu2NUgL2iZ/pI1MSRX0pqYewPf6dd0JjLDyJHETY/Zf/I25exvsbXgwc8FOTZbjKoGKyDQh0eDZnpe7PgCqM9IfooXxxX6OK5Jxhct4sursz8nrFLsjiBR32ZdijEyoUQgtUbFD9dOgsYyAJcUYdH+F9OGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zg47b0+0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zg47b0+0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C12DC4CECD; Wed, 6 Nov 2024 12:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730894888; bh=+fwIoVPk+oWWNS82mXLD4lf6cTbe4tZ3O8AdwAonA2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zg47b0+0XnDZSmUYNldIUG6OgT/MlIsK3U+JFj8k2vei55QKJdAKOzxCPIqnUmWla X1PK+7rLjdk0pO0qbb1uQs+1Y18V9EuKPtxAoEveFbI05L52dyTwwRke6SnamOz7mv GFN8XuC2LQvUckxEdOyQDAPlONcbZz8XFr5VfpZI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Antipov , Johannes Berg , Sasha Levin Subject: [PATCH 4.19 033/350] wifi: cfg80211: fix two more possible UBSAN-detected off-by-one errors Date: Wed, 6 Nov 2024 12:59:21 +0100 Message-ID: <20241106120321.699368042@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120320.865793091@linuxfoundation.org> References: <20241106120320.865793091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Antipov [ Upstream commit 15ea13b1b1fbf6364d4cd568e65e4c8479632999 ] Although not reproduced in practice, these two cases may be considered by UBSAN as off-by-one errors. So fix them in the same way as in commit a26a5107bc52 ("wifi: cfg80211: fix UBSAN noise in cfg80211_wext_siwscan()"). Fixes: 807f8a8c3004 ("cfg80211/nl80211: add support for scheduled scans") Fixes: 5ba63533bbf6 ("cfg80211: fix alignment problem in scan request") Signed-off-by: Dmitry Antipov Link: https://patch.msgid.link/20240909090806.1091956-1-dmantipov@yandex.ru Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/nl80211.c | 3 ++- net/wireless/sme.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index ebd8449f2fcf1..f3f01ab1abd38 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -7578,7 +7578,8 @@ nl80211_parse_sched_scan(struct wiphy *wiphy, struct wireless_dev *wdev, return ERR_PTR(-ENOMEM); if (n_ssids) - request->ssids = (void *)&request->channels[n_channels]; + request->ssids = (void *)request + + struct_size(request, channels, n_channels); request->n_ssids = n_ssids; if (ie_len) { if (n_ssids) diff --git a/net/wireless/sme.c b/net/wireless/sme.c index ebc73faa8fb18..4e6afb765e815 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -116,7 +116,8 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev) n_channels = i; } request->n_channels = n_channels; - request->ssids = (void *)&request->channels[n_channels]; + request->ssids = (void *)request + + struct_size(request, channels, n_channels); request->n_ssids = 1; memcpy(request->ssids[0].ssid, wdev->conn->params.ssid, -- 2.43.0