From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0CE1DF721; Wed, 6 Nov 2024 12:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895027; cv=none; b=sxCUzZoc8C3u1yKqgc4QJu08IAxvN/z27H1CP0MM/ZI8yZhEIAseTJrs6AyPmJTXEvp7MFFIgCB3ajcTnYcJjV63zhcdtXiBdP/xrYjQEKJFN+g5EHVi6pyRpu2ydls2TDhXwb/l5ogPYhclO4UvhFB25svFsMR8jM7YAPNx2Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895027; c=relaxed/simple; bh=bF7dIj2HyASzEITV2aKENfnYztFIN/XnBGa/wLs/SsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sVO48006K9mdtAXjFs5Sjebxc7YVUaW2a97eaictpQnrJdec/uJXVD5g4TNuFen6TwLc0B6jgNCYQyPSN8meW6E/s/WL5oiamhd/W8sg2L3cBknqyj4PewZzR15Jp1Y55MHjYblOdHM51Xar04hssGtorpR4Hwwsdg2QWwVnYc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AAdKZ7bi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AAdKZ7bi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89201C4CECD; Wed, 6 Nov 2024 12:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730895027; bh=bF7dIj2HyASzEITV2aKENfnYztFIN/XnBGa/wLs/SsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AAdKZ7biSm7OO+5hDP+3V7yaLN6KykGY3GlEMiWV2gvk3NBpS7PzRMWdF+ra6P9CU hHSw2p/vCrFUW+uW/uEPaJa0NCMtDd2lnz3sKsaF0oHnqGNTRV1DISUj0kRcf8aR74 vmE8MqxKchAgMmwWpOWijOslOk5r5Rl+C2qJzumY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Jihong , Namhyung Kim , Adrian Hunter , Alexander Shishkin , David Ahern , Ian Rogers , Ingo Molnar , Jiri Olsa , Kan Liang , Mark Rutland , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.19 079/350] perf sched timehist: Fix missing free of session in perf_sched__timehist() Date: Wed, 6 Nov 2024 13:00:07 +0100 Message-ID: <20241106120322.846091483@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120320.865793091@linuxfoundation.org> References: <20241106120320.865793091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Jihong [ Upstream commit 6bdf5168b6fb19541b0c1862bdaa596d116c7bfb ] When perf_time__parse_str() fails in perf_sched__timehist(), need to free session that was previously created, fix it. Fixes: 853b74071110bed3 ("perf sched timehist: Add option to specify time window of interest") Signed-off-by: Yang Jihong Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Alexander Shishkin Cc: David Ahern Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240806023533.1316348-1-yangjihong@bytedance.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-sched.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 4562e3b2f4d36..1c9e06c1d0089 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -2994,7 +2994,8 @@ static int perf_sched__timehist(struct perf_sched *sched) if (perf_time__parse_str(&sched->ptime, sched->time_str) != 0) { pr_err("Invalid time string\n"); - return -EINVAL; + err = -EINVAL; + goto out; } if (timehist_check_attr(sched, evlist) != 0) -- 2.43.0