From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 087CF1DF736; Wed, 6 Nov 2024 12:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895851; cv=none; b=tE/NLa0tiBmFnEQRss7r/iyUzBubqSsBazqgVS1SId1PcaDyrglNXMzMzrfdk1jnOBBNPm06liq+iRtCLVM18Q/59klUtYfgcs1tIqbcDh+XhkEx1VP/Afll9/vV6/+H0lfHib1d6ZEGwsA5M82FjvAHqik5slDHaBc24Ol2Szw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730895851; c=relaxed/simple; bh=xyz7QbfV1FnicddKYd+SbwyQNsV7cv6uVDc4ICWbEjY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sq/FuVG37DMnE0WJt/Sn7hide+orq7CFwx/JUwJPZkNgGSGSEoLPhnWry7qKOozraDQ2pXLohymEu5RVf+cIJm3rhxgSbbn1UYajJQK/SbYo5ASiy74y1+qzpkcW3QWt/wd7ULoD5kbFcNioyGltO9CiojspPT2DzdDjxkT+TSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E0LTmvHs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E0LTmvHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41F57C4CECD; Wed, 6 Nov 2024 12:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730895850; bh=xyz7QbfV1FnicddKYd+SbwyQNsV7cv6uVDc4ICWbEjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E0LTmvHs0tWseXme3RxPCMYv5tE+8mIUXTVhRvGCK72Zn8PWQSMsXFuBf6nKpfWT7 TomEErS3xGOG5EShRGaqHGmn8w+WVlDLAYT9PR3frEulGva6DWAtAo2PYEYIA3LEaQ a/TdxoT++ijGaNL6n+Uss7xvrVpYIzHlKXomiOpY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Byeonguk Jeong , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Hou Tao , Alexei Starovoitov , Sasha Levin Subject: [PATCH 4.19 332/350] bpf: Fix out-of-bounds write in trie_get_next_key() Date: Wed, 6 Nov 2024 13:04:20 +0100 Message-ID: <20241106120328.920117630@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120320.865793091@linuxfoundation.org> References: <20241106120320.865793091@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Byeonguk Jeong [ Upstream commit 13400ac8fb80c57c2bfb12ebd35ee121ce9b4d21 ] trie_get_next_key() allocates a node stack with size trie->max_prefixlen, while it writes (trie->max_prefixlen + 1) nodes to the stack when it has full paths from the root to leaves. For example, consider a trie with max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ... 0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with .prefixlen = 8 make 9 nodes be written on the node stack with size 8. Fixes: b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map") Signed-off-by: Byeonguk Jeong Reviewed-by: Toke Høiland-Jørgensen Tested-by: Hou Tao Acked-by: Hou Tao Link: https://lore.kernel.org/r/Zxx384ZfdlFYnz6J@localhost.localdomain Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- kernel/bpf/lpm_trie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c index fcd3a15add41d..a929ee0e86b16 100644 --- a/kernel/bpf/lpm_trie.c +++ b/kernel/bpf/lpm_trie.c @@ -629,7 +629,7 @@ static int trie_get_next_key(struct bpf_map *map, void *_key, void *_next_key) if (!key || key->prefixlen > trie->max_prefixlen) goto find_leftmost; - node_stack = kmalloc_array(trie->max_prefixlen, + node_stack = kmalloc_array(trie->max_prefixlen + 1, sizeof(struct lpm_trie_node *), GFP_ATOMIC | __GFP_NOWARN); if (!node_stack) -- 2.43.0