From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53F9E1F80AD; Wed, 6 Nov 2024 13:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898065; cv=none; b=BqTaj0/dKr6WQEKhkJpHif0uAs5so+s8MbRK3c9P4beg0QnksXOGbtr3Sz/GEInUSijbg6gfLNL+MumqAoiGj9zb9unRnNM/2cOk0bAAmxu3RtEF7ga1UEwZTxyOPfQPZvpn0xnUR09waei5osS7IOBlaaK76HNCjxvgosywgY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898065; c=relaxed/simple; bh=XXceJ+iXFT/JHq81PjgCJFMtf7HrvYiG5u+0GcMxXM4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cGj4UkwR5ZGX3rzt6cRJadd+FLks4knAD49+b1ZfemyELF/7q1/oR7fuNBggatbrLgHojkov35NKUNCxloNHjhPTCT2WL6xHiTsgLaeyxYIo2Ql8MQI6DUDMGOtH6RXtZlD21N0m2pfONPkDlZ/Y5xT4wDvpmCMeSxPHzuyGGww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NIKQp+9N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NIKQp+9N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC701C4CED3; Wed, 6 Nov 2024 13:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898065; bh=XXceJ+iXFT/JHq81PjgCJFMtf7HrvYiG5u+0GcMxXM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NIKQp+9NYtmW/DhnNalNweMtqEERhsCMzJDDsZvlFiLev0HWbWMeZZkewY/7n70O6 trdl6S8x2h0AJtceZAY2ddOUlnscislDbUCa/gHUGZM+g+FUuByPYH3YeaqTy+HlPx fitArSkWGPelGk3ntw6NTi3neEj6xflcT2OIvw1E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jonas Karlman , Heiko Stuebner , Sasha Levin Subject: [PATCH 5.4 075/462] drm/rockchip: dw_hdmi: Fix reading EDID when using a forced mode Date: Wed, 6 Nov 2024 12:59:28 +0100 Message-ID: <20241106120333.360443729@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonas Karlman [ Upstream commit a5d024541ec466f428e6c514577d511a40779c7b ] EDID cannot be read on RK3328 until after read_hpd has been called and correct io voltage has been configured based on connection status. When a forced mode is used, e.g. video=1920x1080@60e, the connector detect ops, that in turn normally calls the read_hpd, never gets called. This result in reading EDID to fail in connector get_modes ops. Call dw_hdmi_rk3328_read_hpd at end of dw_hdmi_rk3328_setup_hpd to correct io voltage and allow reading EDID after setup_hpd. Fixes: 1c53ba8f22a1 ("drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328") Signed-off-by: Jonas Karlman Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20240615170417.3134517-5-jonas@kwiboo.se Signed-off-by: Sasha Levin --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 7805091bac32d..51ac0a0cd995a 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -390,6 +390,8 @@ static void dw_hdmi_rk3328_setup_hpd(struct dw_hdmi *dw_hdmi, void *data) HIWORD_UPDATE(RK3328_HDMI_SDAIN_MSK | RK3328_HDMI_SCLIN_MSK, RK3328_HDMI_SDAIN_MSK | RK3328_HDMI_SCLIN_MSK | RK3328_HDMI_HPD_IOE)); + + dw_hdmi_rk3328_read_hpd(dw_hdmi, data); } static const struct dw_hdmi_phy_ops rk3228_hdmi_phy_ops = { -- 2.43.0