From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F11B1F7544; Wed, 6 Nov 2024 13:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898272; cv=none; b=lVPdlNwYJToIMHuyb+6dh77Ov6QA7WcCWRzHyWx3rAgXBUNCAEErvH8UV+VYwOH4qJQm11DFP4AkjpSECYGmRJ28Agz1xyGEGmKSWaE5YzoHSyOJKrfPF+wzz9RGSwOk/8C66YN4yZ1cOJ7MDIV+JqYzNGfZ9FbrwUipK7p611A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730898272; c=relaxed/simple; bh=qtbkfxOkquK1cDACGTm8BlaYgGRJwHWUAzaPBKjuzmA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ipzvaIZKqILgNe3jOtF5rxicDBwxwR3/MHNRJXOmNFP8X1MUb/x9Q8v9rPf1akjqD1lyCT/b/iGv2gCR5hv3uTaq5jRLcHccmZJiF9ocF/ejOccYGGL4/rFwAcvu7/asrK19aZA7uS8CzHGLyacvMAc7oHAHKAe66YneJM/m8Zk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lFmy44FM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lFmy44FM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4DA8C4CECD; Wed, 6 Nov 2024 13:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730898272; bh=qtbkfxOkquK1cDACGTm8BlaYgGRJwHWUAzaPBKjuzmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lFmy44FMMI50NiIjLvdH32Y9zc1TbJ8VkJ7r4S2nBR19bEikM19jIek+ieyh5PWLd 8AK8FpVw6JZjjXgpg9PwqupY6RkZ5P3IjKD72ezvAFbs7jNwX8PDD//CR36OCoD36r 6/fLQE6Virg8UykXv0FJcWr2kgPnmh+E1mEprtcw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miquel Raynal , Jinjie Ruan , Stefan Schmidt , Sasha Levin Subject: [PATCH 5.4 181/462] net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq() Date: Wed, 6 Nov 2024 13:01:14 +0100 Message-ID: <20241106120335.987756331@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106120331.497003148@linuxfoundation.org> References: <20241106120331.497003148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit 09573b1cc76e7ff8f056ab29ea1cdc152ec8c653 ] disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Reviewed-by: Miquel Raynal Signed-off-by: Jinjie Ruan Link: https://lore.kernel.org/20240911094234.1922418-1-ruanjinjie@huawei.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- drivers/net/ieee802154/mcr20a.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 383231b854642..16474990dc01e 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -1311,16 +1311,13 @@ mcr20a_probe(struct spi_device *spi) irq_type = IRQF_TRIGGER_FALLING; ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr, - irq_type, dev_name(&spi->dev), lp); + irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), lp); if (ret) { dev_err(&spi->dev, "could not request_irq for mcr20a\n"); ret = -ENODEV; goto free_dev; } - /* disable_irq by default and wait for starting hardware */ - disable_irq(spi->irq); - ret = ieee802154_register_hw(hw); if (ret) { dev_crit(&spi->dev, "ieee802154_register_hw failed\n"); -- 2.43.0