AMD PMF on 6.11.y

AMD PMF on 6.11.y

[Mario Limonciello]

Hi,

6.11 already supports most functionality of AMD family 0x1a model 0x60, 
but the amd-pmf driver doesn't load due to a missing device ID.

The device ID was added in 6.12 with:

commit 8ca8d07857c69 ("platform/x86/amd/pmf: Add SMU metrics table 
support for 1Ah family 60h model")

Can this please come back to 6.11.y to enable it more widely?

Thanks!

Re: AMD PMF on 6.11.y

[Greg KH]

On Wed, Nov 06, 2024 at 11:52:58PM -0600, Mario Limonciello wrote:
> Hi,
> 
> 6.11 already supports most functionality of AMD family 0x1a model 0x60, but
> the amd-pmf driver doesn't load due to a missing device ID.
> 
> The device ID was added in 6.12 with:
> 
> commit 8ca8d07857c69 ("platform/x86/amd/pmf: Add SMU metrics table support
> for 1Ah family 60h model")
> 
> Can this please come back to 6.11.y to enable it more widely?

I would be glad to, but it does not apply cleanly, are you sure you
tried this?

thanks,

greg k-h

Re: AMD PMF on 6.11.y

[Mario Limonciello]

On 11/9/24 09:30, Greg KH wrote:
> On Wed, Nov 06, 2024 at 11:52:58PM -0600, Mario Limonciello wrote:
>> Hi,
>>
>> 6.11 already supports most functionality of AMD family 0x1a model 0x60, but
>> the amd-pmf driver doesn't load due to a missing device ID.
>>
>> The device ID was added in 6.12 with:
>>
>> commit 8ca8d07857c69 ("platform/x86/amd/pmf: Add SMU metrics table support
>> for 1Ah family 60h model")
>>
>> Can this please come back to 6.11.y to enable it more widely?
> 
> I would be glad to, but it does not apply cleanly, are you sure you
> tried this?
> 
> thanks,
> 
> greg k-h

Whoops! I had thought we had the context changes already in 6.11.y and 
got fooled by the one line change.

Here's the correct series.

commit 375780541739 ("platform/x86/amd/pmf: Relocate CPU ID macros to 
the PMF header")
commit 8f2407cb3f1e ("platform/x86/amd/pmf: Update SMU metrics table for 
1AH family series")
commit 8ca8d07857c6 ("platform/x86/amd/pmf: Add SMU metrics table 
support for 1Ah family 60h model")

Thanks,

Re: AMD PMF on 6.11.y

[Greg KH]

On Sat, Nov 09, 2024 at 10:48:37AM -0600, Mario Limonciello wrote:
> 
> 
> On 11/9/24 09:30, Greg KH wrote:
> > On Wed, Nov 06, 2024 at 11:52:58PM -0600, Mario Limonciello wrote:
> > > Hi,
> > > 
> > > 6.11 already supports most functionality of AMD family 0x1a model 0x60, but
> > > the amd-pmf driver doesn't load due to a missing device ID.
> > > 
> > > The device ID was added in 6.12 with:
> > > 
> > > commit 8ca8d07857c69 ("platform/x86/amd/pmf: Add SMU metrics table support
> > > for 1Ah family 60h model")
> > > 
> > > Can this please come back to 6.11.y to enable it more widely?
> > 
> > I would be glad to, but it does not apply cleanly, are you sure you
> > tried this?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Whoops! I had thought we had the context changes already in 6.11.y and got
> fooled by the one line change.
> 
> Here's the correct series.
> 
> commit 375780541739 ("platform/x86/amd/pmf: Relocate CPU ID macros to the
> PMF header")
> commit 8f2407cb3f1e ("platform/x86/amd/pmf: Update SMU metrics table for 1AH
> family series")
> commit 8ca8d07857c6 ("platform/x86/amd/pmf: Add SMU metrics table support
> for 1Ah family 60h model")

Much better thanks!  All now queued up.

greg k-h