From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20D5619E992; Tue, 12 Nov 2024 10:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407012; cv=none; b=o7KTpmhSTnbUPZYZ4RkCZY1rsvrIHaYgfuYBDuepkcDj7M5Lk9RWOXm2U9M2ueWGt0FfYWlfC+HWdxFQNsD44o/8XmVDq+zgBK31hFQWUrwU75J1NyqIHFclb9m1eoX9TEt5p4NyELKk6l0saFNnZJvsWlmxCO2hrn7XofcC/nI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407012; c=relaxed/simple; bh=AuEgug5EjhQ55PpCZ9ca6k+mffawaic1D5yFZZRglo0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G8lP5OD6+IsFa0Xnnv5OC4L77PN8hnzPLI3FHREz616C3M8p1Yh2Oby0AqCi+RlIXBxgE6y6QmuJF6M38l4u4D43288VgeUqv8Sa7n9nJWBLbVPXb55dEwr35YOn80k0OJAX1OqxkyzRTM0ySE9QyyC+0zrRTZkrdGcim+9C0Pw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gPCtFsL+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gPCtFsL+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E53C4CED4; Tue, 12 Nov 2024 10:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731407012; bh=AuEgug5EjhQ55PpCZ9ca6k+mffawaic1D5yFZZRglo0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gPCtFsL+ibZGBq+6fuxt+9wq4blmq4FAuvBs5wrUfqsbjvWL2Po6GtitpO49OJM/m 8qC20K41ERGyVTdTadL0A1N0axPiqT21vNVVZjQaAxN1TOfFbWSQjkvRd60YOX4j8j rQ1t0ggMxQJVULSgZil8HBgAFcYiL7vUXaSXsVfA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "=?UTF-8?q?N=C3=ADcolas=20F . =20R . =20A . =20Prado?=" , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 5.15 23/76] net: stmmac: Fix unbalanced IRQ wake disable warning on single irq case Date: Tue, 12 Nov 2024 11:20:48 +0100 Message-ID: <20241112101840.669926454@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241112101839.777512218@linuxfoundation.org> References: <20241112101839.777512218@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nícolas F. R. A. Prado [ Upstream commit 25d70702142ac2115e75e01a0a985c6ea1d78033 ] Commit a23aa0404218 ("net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls") introduced checks to prevent unbalanced enable and disable IRQ wake calls. However it only initialized the auxiliary variable on one of the paths, stmmac_request_irq_multi_msi(), missing the other, stmmac_request_irq_single(). Add the same initialization on stmmac_request_irq_single() to prevent "Unbalanced IRQ wake disable" warnings from being printed the first time disable_irq_wake() is called on platforms that run on that code path. Fixes: a23aa0404218 ("net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Simon Horman Link: https://patch.msgid.link/20241101-stmmac-unbalanced-wake-single-fix-v1-1-5952524c97f0@collabora.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4a194f30f4a83..2478caeec763f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3650,6 +3650,7 @@ static int stmmac_request_irq_single(struct net_device *dev) /* Request the Wake IRQ in case of another line * is used for WoL */ + priv->wol_irq_disabled = true; if (priv->wol_irq > 0 && priv->wol_irq != dev->irq) { ret = request_irq(priv->wol_irq, stmmac_interrupt, IRQF_SHARED, dev->name, dev); -- 2.43.0