From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C3C2141BC; Tue, 12 Nov 2024 10:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407201; cv=none; b=U6CFRKBXB9yTdDWuFjkFB4GUyO18zzPpoczZJ7AFvdgFTFE6DsDlvhuit4x09ut4681AgoOgwyALRBHQ7th9Mkqv/KVdqPcjuyCqCB/aScbJjOBPtD5wV1bua8TSysUyS2ija+jmgy08Pxs80a5Mv+tT0Q6Sp6MQZsW7F/fEB/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407201; c=relaxed/simple; bh=LEAFOVRKDQ5gk3L+ZWnM6FAXoYp5koRZxqNkF6HDl2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M6UhCQw6bZP7jrdwkdvY2gXFfvJgXygHSsLtk96jWGlAQW22xJGLMMRZWBQcoSoh/5UlRPxxrQf9rVVDCwUHJwY0AJcz6z+dYAlRLGshT8M+5KF72oaONkTm+t00cjMikJNpdN+eqcl0bRTOUOxi2Jt49zmBGrDmInfaJ3IVkhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1T4sDh7/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1T4sDh7/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56B15C4CED4; Tue, 12 Nov 2024 10:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731407200; bh=LEAFOVRKDQ5gk3L+ZWnM6FAXoYp5koRZxqNkF6HDl2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1T4sDh7/D3RtKf3d1YEZ0utEgLGR6k86+O8idFbvztQkO2uYQXVCKGeuQVY3CUr1u 8fgPyjZ1DxcX6KPOycybxpiCziX30q4BD1eSrPMQj2Ahvk48BY+fGrfuzY83mVxYNz p8uYR71AOLJU5Gc3OTC2TpJaPfNrAwMZy1KzAgj8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Johan Hovold Subject: [PATCH 5.15 64/76] USB: serial: io_edgeport: fix use after free in debug printk Date: Tue, 12 Nov 2024 11:21:29 +0100 Message-ID: <20241112101842.222937156@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241112101839.777512218@linuxfoundation.org> References: <20241112101839.777512218@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 37bb5628379295c1254c113a407cab03a0f4d0b4 upstream. The "dev_dbg(&urb->dev->dev, ..." which happens after usb_free_urb(urb) is a use after free of the "urb" pointer. Store the "dev" pointer at the start of the function to avoid this issue. Fixes: 984f68683298 ("USB: serial: io_edgeport.c: remove dbg() usage") Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/io_edgeport.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/usb/serial/io_edgeport.c +++ b/drivers/usb/serial/io_edgeport.c @@ -770,11 +770,12 @@ static void edge_bulk_out_data_callback( static void edge_bulk_out_cmd_callback(struct urb *urb) { struct edgeport_port *edge_port = urb->context; + struct device *dev = &urb->dev->dev; int status = urb->status; atomic_dec(&CmdUrbs); - dev_dbg(&urb->dev->dev, "%s - FREE URB %p (outstanding %d)\n", - __func__, urb, atomic_read(&CmdUrbs)); + dev_dbg(dev, "%s - FREE URB %p (outstanding %d)\n", __func__, urb, + atomic_read(&CmdUrbs)); /* clean up the transfer buffer */ @@ -784,8 +785,7 @@ static void edge_bulk_out_cmd_callback(s usb_free_urb(urb); if (status) { - dev_dbg(&urb->dev->dev, - "%s - nonzero write bulk status received: %d\n", + dev_dbg(dev, "%s - nonzero write bulk status received: %d\n", __func__, status); return; }