From: Greg KH <gregkh@linuxfoundation.org>
To: Agathe Porte <agathe.porte@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields
Date: Tue, 12 Nov 2024 13:12:23 +0100 [thread overview]
Message-ID: <2024111251-buggy-scarily-38dd@gregkh> (raw)
In-Reply-To: <20241112120304.32452-2-agathe.porte@canonical.com>
On Tue, Nov 12, 2024 at 01:01:54PM +0100, Agathe Porte wrote:
> These two fields are populated during and stored as a "frequently used
> value" in ufs_fill_super, but are not used afterwards in the driver.
>
> Moreover, one of the shifts triggers UBSAN: shift-out-of-bounds when
> apbshift is 12 because 12 * 3 = 36 and 1 << 36 does not fit in the 32
> bit integer used to store the value.
>
> Cc: stable@vger.kernel.org
> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087853
As these values are not used, even if the shift goes off in the wild
it's not needed to backport this as it's not actually causing any
problems. So I'd drop the cc: stable@ please.
thanks,
greg k-h
next prev parent reply other threads:[~2024-11-12 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:01 [PATCH v2 0/1] ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields Agathe Porte
2024-11-12 12:01 ` [PATCH v2 1/1] " Agathe Porte
2024-11-12 12:12 ` Greg KH [this message]
2024-11-12 12:21 ` Agathe Porte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111251-buggy-scarily-38dd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=agathe.porte@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox