From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE071885AA; Fri, 15 Nov 2024 06:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652855; cv=none; b=Rgdo7wd0+/SHowo7TERcQuxq5LQLLcR9CJw3+TWG5Z+YRkixrMlbMoGp8rmI09yXILTVj+EPLff3HJc37Zbh5tF0SaTAM/CExz0XU0jLfAaW5vt3kXTnjjgQPA3SRtfl3Latd4AL8jnFBiBJkiLi0ZFFO32B/MCDdmfArqEeYbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652855; c=relaxed/simple; bh=NzRDInUm0G8BAxUcQiwgcB6TspyDB9Qj3oBQkveue4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nQbsxBroqg1zFBjUYYoYJepwUB/GLHjBmbLTYtdBzWXXgatjPrRaM/6Mx3Sj6L/Mvz0yMHguyai1jxzD9L4J7XHfioemmYOenOniBfpBaaHRTNaEwUDC6LnyR0GZ19i65gbMyUkYlq1TluzaiACpVW0WZ/sNaDUY237fdhjDJ4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=G9iTAwdZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="G9iTAwdZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F07C2C4CECF; Fri, 15 Nov 2024 06:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731652855; bh=NzRDInUm0G8BAxUcQiwgcB6TspyDB9Qj3oBQkveue4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9iTAwdZSbXCuE1iDCCyqLGFzm9USspGNITYU487ET30dAma3qwqZyxoGacjh97hH Kzs0J31YmXh499ZvZwKHnf+MljvzdL9Qh3PYKOi3bZvg2NAmDul71q0MrgUfPJO1Fb MwdNVp7ws9WV8Z0mSjshCsTlteN8WD+9weoDhGMs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Beno=C3=AEt=20Sevens?= , Benjamin Tissoires , Jiri Kosina , Sasha Levin Subject: [PATCH 4.19 05/52] HID: core: zero-initialize the report buffer Date: Fri, 15 Nov 2024 07:37:18 +0100 Message-ID: <20241115063723.047266329@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063722.845867306@linuxfoundation.org> References: <20241115063722.845867306@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiri Kosina [ Upstream commit 177f25d1292c7e16e1199b39c85480f7f8815552 ] Since the report buffer is used by all kinds of drivers in various ways, let's zero-initialize it during allocation to make sure that it can't be ever used to leak kernel memory via specially-crafted report. Fixes: 27ce405039bf ("HID: fix data access in implement()") Reported-by: Benoît Sevens Acked-by: Benjamin Tissoires Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 0757097d25507..3387e64d84412 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1482,7 +1482,7 @@ u8 *hid_alloc_report_buf(struct hid_report *report, gfp_t flags) u32 len = hid_report_len(report) + 7; - return kmalloc(len, flags); + return kzalloc(len, flags); } EXPORT_SYMBOL_GPL(hid_alloc_report_buf); -- 2.43.0