From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 032F8188724; Fri, 15 Nov 2024 06:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652862; cv=none; b=uHq25OymQUGIKXi4t5k8DZV7Lis+PjpQjywn9FJmThxvsa459/JeKPyPdDLVc7yvbsH5MI6bsCR1r88kLNDPrZXGz8f0p/AxtZV5ociD7U1OHnlkBqEQRz8RqBE+LRHWMOaSA8QfIXkAP4XGKRSCdAvTRRdayV95STYrBU6b7WU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731652862; c=relaxed/simple; bh=Cnr8FMJMwNBZejGaM1d1aUyUHThXq4ACqGv7ggJlgbA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WuDXnfzQ2TmOc1G5wVkcY1Z4tz+/lge0rG05VoEMvtEqwp4mBXRaGMZgbEduJoUbYcNXqpdYVjfsR3KPnSpibfYo/6dPMOxFYsXpkrZPRXY6+6VuBmAh12F1Fq39L9EIvnpYg8jpOW9SrmjuyVKjiKMCITGGD4NYoHF3d+9ttlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2YXvnC3G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2YXvnC3G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68CFDC4CECF; Fri, 15 Nov 2024 06:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731652861; bh=Cnr8FMJMwNBZejGaM1d1aUyUHThXq4ACqGv7ggJlgbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2YXvnC3GINjPPiKcbN9+1ZRXOy3yKB7mInJZVf1NJ64zWWWlWb9G4Y9wrD+kueoi1 qoRK135jQKGdtR5185wBhO1v8imtCbBP0SyAPLxUTfrlFRVeYYdwXHElvfi2Oh/Msr 1BTNZE3rrM1ZOrIz4/PEcm60VZ0QxqHI8t9aKumU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+f0cbb34d39392f2746ca@syzkaller.appspotmail.com, Xin Long , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.19 07/52] sctp: properly validate chunk size in sctp_sf_ootb() Date: Fri, 15 Nov 2024 07:37:20 +0100 Message-ID: <20241115063723.118837222@linuxfoundation.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115063722.845867306@linuxfoundation.org> References: <20241115063722.845867306@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit 0ead60804b64f5bd6999eec88e503c6a1a242d41 ] A size validation fix similar to that in Commit 50619dbf8db7 ("sctp: add size validation when walking chunks") is also required in sctp_sf_ootb() to address a crash reported by syzbot: BUG: KMSAN: uninit-value in sctp_sf_ootb+0x7f5/0xce0 net/sctp/sm_statefuns.c:3712 sctp_sf_ootb+0x7f5/0xce0 net/sctp/sm_statefuns.c:3712 sctp_do_sm+0x181/0x93d0 net/sctp/sm_sideeffect.c:1166 sctp_endpoint_bh_rcv+0xc38/0xf90 net/sctp/endpointola.c:407 sctp_inq_push+0x2ef/0x380 net/sctp/inqueue.c:88 sctp_rcv+0x3831/0x3b20 net/sctp/input.c:243 sctp4_rcv+0x42/0x50 net/sctp/protocol.c:1159 ip_protocol_deliver_rcu+0xb51/0x13d0 net/ipv4/ip_input.c:205 ip_local_deliver_finish+0x336/0x500 net/ipv4/ip_input.c:233 Reported-by: syzbot+f0cbb34d39392f2746ca@syzkaller.appspotmail.com Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Xin Long Link: https://patch.msgid.link/a29ebb6d8b9f8affd0f9abb296faafafe10c17d8.1730223981.git.lucien.xin@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sctp/sm_statefuns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 8298f27e8de0d..0b44ad00dbb69 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -3652,7 +3652,7 @@ enum sctp_disposition sctp_sf_ootb(struct net *net, } ch = (struct sctp_chunkhdr *)ch_end; - } while (ch_end < skb_tail_pointer(skb)); + } while (ch_end + sizeof(*ch) < skb_tail_pointer(skb)); if (ootb_shut_ack) return sctp_sf_shut_8_4_5(net, ep, asoc, type, arg, commands); -- 2.43.0